Skip to content

refactor execSelector #3056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 8, 2025
Merged

refactor execSelector #3056

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8bfc641
refactor execSelector
kfule Nov 7, 2025
3bf5efa
Merge branch 'main' into refactor-execSelector
dead-claudia Nov 8, 2025
86ceb03
Merge branch 'main' into refactor-execSelector
dead-claudia Nov 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions render/hyperscript.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,24 +51,21 @@ function execSelector(state, vnode) {
return vnode
}

var hasClass = hasOwn.call(attrs, "class")
var className = hasClass ? attrs.class : attrs.className
if (hasOwn.call(attrs, "class")) {
if (attrs.class != null) attrs.className = attrs.class
attrs.class = null
}

if (state.attrs !== emptyAttrs) {
var className = attrs.className
attrs = Object.assign({}, state.attrs, attrs)

if (className != null || state.attrs.className != null) attrs.className =
if (state.attrs.className != null) attrs.className =
className != null
? state.attrs.className != null
? String(state.attrs.className) + " " + String(className)
: className
? String(state.attrs.className) + " " + String(className)
: state.attrs.className
} else {
if (className != null) attrs.className = className
}

if (hasClass) attrs.class = null

// workaround for #2622 (reorder keys in attrs to set "type" first)
// The DOM does things to inputs based on the "type", so it needs set first.
// See: https://github.com/MithrilJS/mithril.js/issues/2622
Expand Down