Release - v2.3.8 #3046
Merged
Release - v2.3.8 #3046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olexandr88 <[email protected]>
Bumps the normal group with 1 update: [actions/setup-node](https://github.com/actions/setup-node). Updates `actions/setup-node` from 4 to 5 - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-node dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major dependency-group: normal ... Signed-off-by: dependabot[bot] <[email protected]>
JAForbes
added
dependencies
setImmediate() is not supported in almost all environments except IE11. Furthermore, by not using setImmediate(), the assignment code to callAsync itself, which takes non-browser environments into account, can be removed.
The `window` is no longer used within m.render().
The bundle size can be reduced by removing the intermediate object used to export domFor and delayedRemoval. Additionally, the file paths used in domFor-related require() calls have been standardized.
…ith one shared version
…undle by changing the module loading order and variable name Mithril's internal bundler enables module bundling without generating intermediate variables by carefully managing module loading order and variable names. This commit prevents assigning `mountRedraw`, `decodeURIComponentSave`, and `hyperscript` to intermediate variables. It also improves readability by moving all member additions for `m` to the end of the file.
Some router-related tests have fixed issues where UTF-8 strings were not decoded.
… types This will make the results more consistent with decodeURIComponent.
…rect mangling by internal bundler
Because "c" was being improperly mangled and the "c0" suffix was being improperly removed, it was changed to "c[01]" rather than just dropping the literal use.
Also, since the backslash in "\d" is escaped ("\\d"), I simply changed it to "0-9" of the same string length.
…n the internal bundler This allows regular expression literals to be used even where RegExp() was previously used as a workaround.
Like the issue addressed in #3000, it seemed that the performance of mithril.min.js had degraded again. I tried some compression options for terser and found that disabling the `conditionals` option improved performance and also reduced the bundle size.
It seemed that, for example, `var i` might cause a suffix to be added to the "i" flag within a regular expression literal. So the entire regular expression literal, including flags, is now corrected within the bundler.
Bumps the normal group with 1 update: [actions/setup-node](https://github.com/actions/setup-node). Updates `actions/setup-node` from 5 to 6 - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v5...v6) --- updated-dependencies: - dependency-name: actions/setup-node dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major dependency-group: normal ... Signed-off-by: dependabot[bot] <[email protected]>
…cy checks after normalization This change preallocates the array to the input length and collapses multiple loops into a single pass. Assigning immediately after preallocation improves performance on V8 (generally neutral elsewhere). Key checks are now performed on normalized vnodes, making the consistency validation more accurate and clarifying the correspondence between error messages and code. Perf-sensitive comments have been clarified to reflect the original intent of commit 6c562d2. Behavior is unchanged, except that the timing/order of related errors may differ slightly. All existing tests pass. Additionally, bundle size is slightly reduced.
Bumps the normal group with 1 update: [rimraf](https://github.com/isaacs/rimraf). Updates `rimraf` from 6.0.1 to 6.1.0 - [Changelog](https://github.com/isaacs/rimraf/blob/main/CHANGELOG.md) - [Commits](isaacs/rimraf@v6.0.1...v6.1.0) --- updated-dependencies: - dependency-name: rimraf dependency-version: 6.1.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: normal ... Signed-off-by: dependabot[bot] <[email protected]>
For fragment and component vnodes, the assignment of `vnode.domSize` was inconsistent between create and update. In particular, when the fragment vnode corresponded to exactly one DOM node, it was set to `1` on creation but left `undefined` on update. Although leaving it undefined in the single-node case was intentional, it reduced behavioral consistency and code readability. This commit aligns the behavior between creation and update. To minimize internal impact from `domSize` transitioning from `undefined` to `1`, additional checks were added in the move and remove paths.
This was a supplemental comment about capturing DOM nodes in `vnode.instance`, but the related code has already been removed.
This commit fully separates the normalization of `class` and `className` from the merging of `vnode.attrs` and `vnode.state.attrs`, which were previously handled together in the same code path. This simplifies conditional branches and improves bundle size and performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release v2.3.8
vnode.domSizeassignment consistent between create and update. #3055Vnode.normalizeChildren#3052Changelog
Patch Changes
refactor execSelector (@kfule)
Make
vnode.domSizeassignment consistent between create and update. (@kfule)This PR makes the code and behavior of create and update processes more consistent.
Bump rimraf from 6.0.1 to 6.1.0 in the normal group (@dependabot[bot])
Bumps the normal group with 1 update: rimraf. Updates
rimraffrom 6.0.1 to 6.1.0. Changelog. Sourced from rimraf's changelog.Fix URI decoder bug and reduce bundle size through module tailoring and cleanup (@kfule)
This fixes the URI decoder used in the Router to decode more strictly.
refactor
Vnode.normalizeChildren(@kfule)Vnode.normalizeChildrennow preallocates the array length and performs key-consistency checks after normalization.Bump actions/setup-node from 5 to 6 in the normal group (@dependabot[bot])
Bumps the normal group with 1 update: actions/setup-node. Updates
actions/setup-nodefrom 5 to 6. Release notes.Bump actions/setup-node from 4 to 5 in the normal group (@dependabot[bot])
Bumps the normal group with 1 update: actions/setup-node. Updates
actions/setup-nodefrom 4 to 5. Release notes.docs: edited the link to the build badge (@Olexandr88)