Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gh-pages): Correct Ospec link #2863

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

bmc1995
Copy link

@bmc1995 bmc1995 commented Aug 28, 2023

The previous link led to a 404 page; Ospec is no longer part of the main code base

Description

The Ospec link has been changed from https://github.com/MithrilJS/mithril.js/blob/master/ospec to https://github.com/MithrilJS/ospec

Motivation and Context

Fixes #2859

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/changelog.md

@dead-claudia
Copy link
Member

dead-claudia commented Sep 1, 2023

Is there a corresponding PR against next, to ensure future docs builds don't include the bad link? Or is next all okay?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants