Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GIT_EDITOR environment variable #941

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Use GIT_EDITOR environment variable #941

merged 1 commit into from
Aug 12, 2024

Conversation

injust
Copy link
Contributor

@injust injust commented Aug 3, 2024

Fixes #939

@injust
Copy link
Contributor Author

injust commented Aug 3, 2024 •
edited
Loading

When reviewing, please keep in mind that I don't know any Rust 😅

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10225671262

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 97.325%
Totals Coverage Status
Change from base Build 10032197327: 0.002%
Covered Lines: 4584
Relevant Lines: 4710
💛 - Coveralls

MitMaro
MitMaro approved these changes Aug 12, 2024
View reviewed changes
Copy link
Owner

@MitMaro MitMaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed issue as well as a great pull request.

@MitMaro MitMaro merged commit e2ac211 into MitMaro:master Aug 12, 2024
7 checks passed
@injust injust deleted the GIT_EDITOR branch August 12, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MitMaro MitMaro MitMaro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GIT_EDITOR environment variable isn't checked
3 participants
@injust @coveralls @MitMaro