add disableZoom and disableFullScreen options #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helias
reviewed
Aug 21, 2024
Helias
reviewed
Aug 21, 2024
Helias
approved these changes
Aug 21, 2024
Miorey
reviewed
Aug 21, 2024
index.js
Outdated
Comment on lines
65
to
70
| $(containerSelector + ' canvas').firstOn('dblclick', (event) => { | ||
| if ( window.fullScreenDisabled === true) event.stopImmediatePropagation(); | ||
| }) | ||
| $(containerSelector + ' canvas').firstOn('DOMMouseScroll mousewheel', (event) => { | ||
| if ( window.zoomDisabled === true) event.stopImmediatePropagation(); | ||
| }) |
There was a problem hiding this comment.
I think you should put this in class WowModelViewer
On a same webpage you can have multiple models.
Ex a mount and pet shop and maybe you will not want to make the same restriction on all elements
The model viewer can display:
- Characters
- NPCs
- Creatures
- Mounts
- Pets
- Items
- Game objects
| @@ -59,3 +65,42 @@ const WH = window.WH | |||
| export { | |||
| WH, | |||
| } | |||
|
|
|||
| function firstOnApply (opts) { | |||
Comment on lines
+82
to
+85
| Array.prototype.splice.apply( | ||
| curEventListeners, | ||
| [0, curEventListeners.delegateCount].concat(delegatedListeners) | ||
| ) |
There was a problem hiding this comment.
Suggested change
| Array.prototype.splice.apply( | |
| curEventListeners, | |
| [0, curEventListeners.delegateCount].concat(delegatedListeners) | |
| ) | |
| curEventListeners.splice(0, curEventListeners.delegateCount, ...delegatedListeners); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.