Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved supports for in-app/game notifications and toasts #587

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Improved supports for in-app/game notifications and toasts #587

wants to merge 13 commits into from

Conversation

BenCheung0422
Copy link
Member

@BenCheung0422 BenCheung0422 commented Nov 15, 2023 •
edited
Loading

This feature is reserved for future use. This adds a support for in-app notifications, where toasts in the screen. It is different from in-game notifications, bare text only, as this includes a frame, and the color can be changed. This is important when there are some alerts, warnings and important information needed to notify the users.

I have several ideas about box popups and notifications: (fading is not supported right now)

  • App status bar with icons (fade inappear fade outdisappear) - quick inspections about status (top bar near top-right)
  • Toast notifications (slide in slide out) - quick informative notification (near top-right/bottom-right corner sliding on side)
  • Bottom slide popup (slide in slide out) - app tool bar? But currently there is no such possible uses. (near bottom-right corner sliding on bottom)

Position for toasts may be configurable to upper or lower positions (also for each type of toast notification?).

Additionally, achievement unlocking toast is added to replace the text-only notifications regarding unlocking achievements. (https://discord.com/channels/280723930942013440/1141498209634623539)
This improves visual quality of life.

@BenCheung0422 BenCheung0422 mentioned this pull request Nov 19, 2023
Draft
@BenCheung0422
Copy link
Member Author

BenCheung0422 commented Dec 30, 2023 •
edited
Loading

Demo from #588:

Minicraft.Plus.2023-12-31.02-24-16.-.Trim.mp4

@Makkkkus
Copy link
Member

Makkkkus commented Jan 7, 2024

In-app notifications are usually a result of bad game design. Using this will make the game feel more like a cheap mobile game than an free and open-source sandbox game. Perhaps an icon can be showed insted when a controller is plugged in?

@BenCheung0422
Merge remote-tracking branch 'upstream/main' into notification
939c80a 
# Conflicts:
#	src/client/java/minicraft/item/FishingRodItem.java
#	src/client/java/minicraft/item/SummonItem.java
#	src/client/java/minicraft/screen/AchievementsDisplay.java
@BenCheung0422
Add AppToast in place of Notification
beb692b
@BenCheung0422
Copy link
Member Author

New design for toast notifications

Minicraft.Plus.2024-02-09.11-48-17.mp4

@BenCheung0422
Copy link
Member Author

BenCheung0422 commented Feb 9, 2024 •
edited
Loading

App status top bar (shows automatically for 2 seconds on startup and shown when "9" (I was seeking to use symbols but it seems like they are not supported, which is not rightActually it is possible, but with different wordings) is down)

Minicraft.Plus.2024-02-09.17-32-31.mp4

@BenCheung0422 BenCheung0422 changed the title Add support for in-app notifications Improved supports for in-app/game notifications and toasts Feb 9, 2024
@BenCheung0422
Copy link
Member Author

BenCheung0422 commented Feb 9, 2024 •
edited
Loading

The new achievement unlocking toast, replacing the original text-only notification.

Minicraft.Plus.2024-02-09.19-37-49.mp4

@BenCheung0422
Copy link
Member Author

Updates has been made for this pull request regarding the issues and it is now ready for review again.

Makkkkus
Makkkkus requested changes Feb 12, 2024
View reviewed changes
Copy link
Member

@Makkkkus Makkkkus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new changes look great!

Although, app toast and game toast should be merged to just be game toast. Having two is unneccecary.

@BenCheung0422
Copy link
Member Author

Ok, it is removed.

@BenCheung0422 BenCheung0422 mentioned this pull request Apr 11, 2024
Merged
@Litorom
Copy link
Member

Litorom commented Jun 25, 2024

Can you update this please.

@BenCheung0422
Merge remote-tracking branch 'upstream/main' into notification
519cb28 
# Conflicts:
#	src/client/java/minicraft/core/Renderer.java
#	src/client/java/minicraft/screen/TutorialDisplayHandler.java
@BenCheung0422
Copy link
Member Author

Okay, branch updated.

Litorom and others added 2 commits June 27, 2024 17:00
@Litorom
Merge branch 'main' into notification
df55f94
@BenCheung0422
Merge remote-tracking branch 'upstream/main' into notification
5005995 
# Conflicts:
#	src/client/java/minicraft/entity/furniture/DeathChest.java
@BenCheung0422 BenCheung0422 mentioned this pull request Dec 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Makkkkus Makkkkus Makkkkus requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenCheung0422 @Makkkkus @Litorom