-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a Debug Panel #504
base: main
Are you sure you want to change the base?
Adds a Debug Panel #504
Conversation
However, I think there might be too many key bindings and that might make confusion. |
It doesn't matter. They're only possible to use when using debug mode. |
It can still be a problem as sometimes looking-up for key bindings is still required if the key bindings are forgotten or not yet known. |
That's why we have our wiki. Using F3 or F4 won't change that. |
And a in-game instant lookup. F3 only triggers the debugging information panel, but this F4 triggers an action panel. |
Yeah, it's not needed. |
There are 23 associated debugging key bindings, if every time using the bindings requires lookup, using built-in interface with only 1 key would be better than opening up the wiki page on browser and find line by line the key bindings required. This compresses 23 key bindings into 1 key. Sometimes, if it is required to add debugging functions, new key bindings are always needed, but in the panel, it is not a hard requirement. |
I'll reopen this on the condition that you readd the --debug launch argument. |
# Conflicts: # src/client/java/minicraft/screen/DebugPanelDisplay.java
I have re-added |
There could be a function to area set tiles with using menus (inputs) and some more useful functions can be used for making maps? |
I don't understand what you mean? |
When making maps, special actions to changes tiles and entities are required. Testing some features may also require large range tiles. |
Still don't understand. Creating maps? |
Customizing worlds in creative mode. Although there are currently no trends in making maps and publishing maps because there is lack of this kind of functionality, testing some features is still requiring an environmental setup and that might require major change to the testing world. Having this kind of debugging or creative mode exclusive functions could reduce the work required and make convenience. Some of this kind of functions I can think of are tile setting, region filling, entity summoning, potion effect modifying, etc. |
What do you want to do? |
Add a debug function entry in the panel and use menus to do the actions. |
We already have creative mode. Don't destroy that. |
It also adds another function to creative mode, like Minecraft's |
Okay. That's something I see the use for. |
We might change some of them into string commands if we need to. Also, the implementations of the commands proposed previously have been done. |
I have reviewed the PR, but I don't approve of the changes as explained in Discord. |
# Conflicts: # src/client/java/minicraft/core/Updater.java # src/client/java/minicraft/core/io/Localization.java # src/client/java/minicraft/entity/mob/Player.java # src/client/java/minicraft/level/tile/Tiles.java # src/client/java/minicraft/network/Analytics.java # src/client/java/minicraft/screen/Menu.java # src/client/java/minicraft/screen/TitleDisplay.java
# Conflicts: # src/client/java/minicraft/core/Updater.java # src/client/java/minicraft/level/tile/Tiles.java
This adds a debug panel and removes all in-world debugging key bindings. This could make the key bindings cleaner and neat. Instead, a list entry menu (triggered by F4) is used and searching is available. (No localization) This would be a way to organize all the debugging functions and features without a lot of (confusing or messy) key bindings.