Multiple file delete end dev closewv2 #3114
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we have implemented profile's Delete API, but it has some bugs, so we should modify it.
At present, the relationship between profile and WebView is:
One profile can have multiple WebView, those WebView can be in same process or different process.
InPrivate profile share same local file with normal profile.
So, when Delete API is called, we should raise an event handle to tell every webview2 under this profile that the profile has called Delete API.
Local files delete logic of Delete API will follow Edge’s delete logic. And the Edge’s profile delete logic is:
The Delete API new design is based on the above fact. When Delete API is called, the actions are:
Profile.ProfileDeletionStarted
to notify each profile. It is recommended to do some clean works and then close the webview2.