-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move samples repos Readme content into regular Docs #2069
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was very clean. I hardly found anything.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@nishitha-burman - please review and possibly approve this PR. @Reezaali @captainbrosset fyi/test msg
|
This comment was marked as outdated.
This comment was marked as outdated.
As discussed with Michael offline, Nishitha has already approved this somewhere else. So I'll go ahead and merge this. |
Rendered pages for review, esp. the 3 nav pages: Getstart, Sample apps, & Deployment samples:
https://review.docs.microsoft.com/en-us/microsoft-edge/webview2/get-started/get-started?branch=pr-en-us-2069
Before:
https://docs.microsoft.com/en-us/microsoft-edge/webview2/get-started/get-started
Readmes in WebView2Samples repo:
PR 140: MicrosoftEdge/WebView2Samples#140
Before:
https://github.com/MicrosoftEdge/WebView2Samples/blob/main/README.md
Readme in WebView2Browser repo:
No PR
https://github.com/MicrosoftEdge/WebView2Browser/blob/main/README.md