2nd Remove adding credentials to Web.config #1767
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Rick-Anderson : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit ecf25e3: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
@GrabYourPitchforks @blowdart See Troubleshooting Forms Authentication here's a better PR |
aartig13
reviewed
Jan 15, 2025
| </forms> | ||
| </authentication> | ||
| ``` | ||
| You can configure forms authentication by using the authentication configuration element. For instance, you have a login page. In the configuration file, you specify a URL to redirect unauthenticated requests to the login page. |
There was a problem hiding this comment.
Should we keep the sentence about defining credentials?
Suggested change
| You can configure forms authentication by using the authentication configuration element. For instance, you have a login page. In the configuration file, you specify a URL to redirect unauthenticated requests to the login page. | |
| You can configure forms authentication by using the authentication configuration element. For instance, you have a login page. In the configuration file, you specify a URL to redirect unauthenticated requests to the login page. Then define valid credentials, either in the *Web.config* file or in a separate file. |
There was a problem hiding this comment.
I'd remove it. Aside from it being SHA1 (ha), it's such a bad practice why discuss it at all?
blowdart
suggested changes
Jan 15, 2025
...veloper/webapps/iis/www-authentication-authorization/troubleshooting-forms-authentication.md
Show resolved
Hide resolved
| </forms> | ||
| </authentication> | ||
| ``` | ||
| You can configure forms authentication by using the authentication configuration element. For instance, you have a login page. In the configuration file, you specify a URL to redirect unauthenticated requests to the login page. |
| </forms> | ||
| </authentication> | ||
| ``` | ||
| You can configure forms authentication by using the authentication configuration element. For instance, you have a login page. In the configuration file, you specify a URL to redirect unauthenticated requests to the login page. |
There was a problem hiding this comment.
I'd remove it. Aside from it being SHA1 (ha), it's such a bad practice why discuss it at all?
Rick-Anderson
commented
Jan 16, 2025
...veloper/webapps/iis/www-authentication-authorization/troubleshooting-forms-authentication.md
Outdated
Show resolved
Hide resolved
…/troubleshooting-forms-authentication.md
|
Learn Build status updates of commit 109f7fe: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1766
Pull request guidance
Thank you for submitting your contribution to our support content! Our team works closely with subject matter experts in CSS and PMs in the product group to review all content requests to ensure technical accuracy and the best customer experience. This process can sometimes take one or more days, so we greatly appreciate your patience.
We also need your help in order to process your request as soon as possible:
We won't act on your pull request (PR) until you type "#sign-off" in a new comment in your pull request (PR) to indicate that your changes are complete.
After you sign off in your PR, the article will be tech reviewed by the PM or SME if it has more than minor changes. Once the article is approved, it will undergo a final editing pass before being merged.