Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Removed multichain flag for v1 release #24362

Merged
merged 13 commits into from May 9, 2024
Merged

Conversation

NidhiKJha
Copy link
Member

This PR is to remove all the Multichain flags from code except the send and swap flow

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2431

Manual testing steps

  1. Run the extension without Multichain flag.
  2. All the changes should be there

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NidhiKJha NidhiKJha requested a review from a team as a code owner May 3, 2024 11:17
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label May 3, 2024
@NidhiKJha NidhiKJha requested review from a team as code owners May 6, 2024 06:53
@NidhiKJha NidhiKJha added team-wallet-ux needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels May 6, 2024
@metamaskbot metamaskbot added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 6, 2024
@salimtb
Copy link
Contributor

salimtb commented May 6, 2024

@NidhiKJha you have 1 broken unit test

Copy link
Contributor

github-actions bot commented May 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sleepytanya
Copy link
Contributor

I'm not sure if 'Select networks for each site' in Experimental settings should be ON by default?
Seems like multichain doesn't work correctly? Sorry, if I'm missing something :).

noFlag.mov

Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 30.00000% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 67.45%. Comparing base (ed850ee) to head (ef8a63d).

Files Patch % Lines
ui/index.js 0.00% 12 Missing ⚠️
ui/components/multichain/app-header/app-header.js 0.00% 1 Missing ⚠️
...i/components/multichain/global-menu/global-menu.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #24362      +/-   ##
===========================================
+ Coverage    67.37%   67.45%   +0.08%     
===========================================
  Files         1286     1286              
  Lines        50114    50077      -37     
  Branches     13004    12985      -19     
===========================================
+ Hits         33761    33777      +16     
+ Misses       16353    16300      -53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [3f07521]
Page Load Metrics (944 ± 636 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint701831062814
domContentLoaded96623168
load5633899441324636
domInteractive96623168
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 529 Bytes (0.01%)
  • common: 96 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [ef8a63d]
Page Load Metrics (659 ± 494 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7012787168
domContentLoaded9441794
load5626266591029494
domInteractive9441794
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 938 Bytes (0.01%)
  • common: 96 Bytes (0.00%)

Copy link
Contributor

@jpuri jpuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the code owned by confirmations team in the PR, code changes look good to me.

@NidhiKJha NidhiKJha merged commit 4dce340 into develop May 9, 2024
72 checks passed
@NidhiKJha NidhiKJha deleted the mc-flag-removal branch May 9, 2024 07:27
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 9, 2024
@metamaskbot metamaskbot added the release-11.18.0 Issue or pull request that will be included in release 11.18.0 label May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-11.18.0 Issue or pull request that will be included in release 11.18.0 team-wallet-ux
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

7 participants