New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Removed multichain flag for v1 release #24362
Conversation
@NidhiKJha you have 1 broken unit test |
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
I'm not sure if 'Select networks for each site' in Experimental settings should be ON by default? noFlag.mov |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #24362 +/- ##
===========================================
+ Coverage 67.37% 67.45% +0.08%
===========================================
Files 1286 1286
Lines 50114 50077 -37
Branches 13004 12985 -19
===========================================
+ Hits 33761 33777 +16
+ Misses 16353 16300 -53 ☔ View full report in Codecov by Sentry. |
Builds ready [3f07521]
Page Load Metrics (944 ± 636 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [ef8a63d]
Page Load Metrics (659 ± 494 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the code owned by confirmations team in the PR, code changes look good to me.
This PR is to remove all the Multichain flags from code except the send and swap flow
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2431
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist