feat: set useRequestQueue on by default #24274

NidhiKJha · 2024-04-29T07:15:02Z

This PR is to ensure that useRequestQueue is set to true by default. After setting it to true, it turn the setting on for all users while keeping the toggle, since this is a state update. This PR also includes a migration.

Related issues

Fixes: #23985

Manual testing steps

Go to settings > Experimental
Check Select networks for each site toggle is on
Toggle should work properly

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

jonybur · 2024-04-29T12:35:09Z

app/scripts/migrations/118.ts

+ return versionedData;
+}
+
+// TODO: Replace `any` with specific type


Can we fix this TODO?

jonybur · 2024-04-29T12:44:48Z

app/scripts/migrations/118.ts

+ return state;
+ }
+
+ if (!isObject(state.PreferencesController)) {


What sort of values can state.PreferencesController have?

github-actions · 2024-04-30T10:40:35Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

adonesky1 · 2024-05-01T17:28:08Z

MetaMask provider should inform dapp when switching networks is failing because the expected behavior its testing has actually changed: we should no longer expect for the network of the dapp not to change when you change the network in network switcher in full screen

adonesky1 · 2024-05-03T17:27:01Z

This PR should resolve at least one of the test failures on this PR: Test Snap RPC can use the cross-snap RPC endowment and produce a public key

…removed

metamaskbot · 2024-05-07T19:57:10Z

Builds ready [4b5956f]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8
- content-script: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1032 ± 635 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	60	173	96	31	15
		domContentLoaded	9	71	21	17	8
		load	49	3135	1032	1322	635
		domInteractive	9	71	21	17	8

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.12 KiB (0.03%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

codecov · 2024-05-07T19:57:23Z

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 67.37%. Comparing base (d27a233) to head (4b5956f).
Report is 23 commits behind head on develop.

Files	Patch %	Lines
app/scripts/migrations/119.ts	83.33%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #24274    +/-   ##
=========================================
  Coverage    67.37%   67.37%            
=========================================
  Files         1278     1286     +8     
  Lines        49881    50070   +189     
  Branches     12944    12997    +53     
=========================================
+ Hits         33605    33734   +129     
- Misses       16276    16336    +60

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

adonesky1 · 2024-05-07T21:10:07Z

test/e2e/tests/dapp-interactions/provider-api.spec.js

@@ -9,47 +9,6 @@ const {
 const FixtureBuilder = require('../../fixture-builder');

 describe('MetaMask', function () {
- it('provider should inform dapp when switching networks', async function () {


I suppose we could add this back with the step to toggle off the setting, like we did with the wallet_switchEthereumChain e2e test

adonesky1 · 2024-05-07T21:10:54Z

test/e2e/json-rpc/switchEthereumChain.spec.js

@@ -29,6 +29,28 @@ describe('Switch Ethereum Chain for two dapps', function () {
 async ({ driver }) => {


we should possibly add either a comment or some note in the description about how this toggles off the per dapp selected network setting

metamaskbot · 2024-05-23T23:08:31Z

Missing release label release-11.17.0 on PR. Adding release label release-11.17.0 on PR and removing other release labels(release-11.18.0), as PR was added to branch 11.17.0 when release was cut.

NidhiKJha requested a review from a team as a code owner April 29, 2024 07:15

NidhiKJha added team-wallet-ux needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Apr 29, 2024

metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Apr 29, 2024

jonybur requested changes Apr 29, 2024

View reviewed changes

NidhiKJha requested a review from kumavis as a code owner April 30, 2024 10:40

NidhiKJha force-pushed the fix-23985 branch 2 times, most recently from ca46fcc to 1644fac Compare April 30, 2024 10:44

metamaskbot added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 6, 2024

salimtb previously approved these changes May 6, 2024

View reviewed changes

hesterbruikman added the amon-hen-v1 Represents blocking issues for the release of Amon Hen label May 7, 2024

NidhiKJha added 3 commits May 7, 2024 23:29

set useRequestQueue on by default

a2de35f

updated state values

e611d02

updated provider api spec

30cb388

NidhiKJha dismissed salimtb’s stale review via 30cb388 May 7, 2024 18:00

NidhiKJha force-pushed the fix-23985 branch from 01e27ea to 30cb388 Compare May 7, 2024 18:00

NidhiKJha and others added 2 commits May 7, 2024 23:32

added migrations

1e145fd

toggle off useRequestQueue setting for e2e tests until the toggle is …

4b5956f

…removed

darkwing approved these changes May 7, 2024

View reviewed changes

jonybur approved these changes May 7, 2024

View reviewed changes

adonesky1 reviewed May 7, 2024

View reviewed changes

NidhiKJha merged commit a51eb93 into develop May 8, 2024
72 checks passed

NidhiKJha deleted the fix-23985 branch May 8, 2024 04:27

github-actions bot locked and limited conversation to collaborators May 8, 2024

github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 8, 2024

metamaskbot added the release-11.18.0 label May 8, 2024

metamaskbot added release-11.17.0 and removed release-11.18.0 labels May 23, 2024

gauthierpetetin added the release-12.0.0 label Jun 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: set useRequestQueue on by default #24274

feat: set useRequestQueue on by default #24274

NidhiKJha commented Apr 29, 2024

jonybur Apr 29, 2024

jonybur Apr 29, 2024

github-actions bot commented Apr 30, 2024

adonesky1 commented May 1, 2024

adonesky1 commented May 3, 2024

metamaskbot commented May 7, 2024

codecov bot commented May 7, 2024

adonesky1 May 7, 2024

adonesky1 May 7, 2024

metamaskbot commented May 23, 2024

		@@ -29,6 +29,28 @@ describe('Switch Ethereum Chain for two dapps', function () {
		async ({ driver }) => {

feat: set useRequestQueue on by default #24274

feat: set useRequestQueue on by default #24274

Conversation

NidhiKJha commented Apr 29, 2024

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

jonybur Apr 29, 2024

Choose a reason for hiding this comment

jonybur Apr 29, 2024

Choose a reason for hiding this comment

github-actions bot commented Apr 30, 2024

adonesky1 commented May 1, 2024

adonesky1 commented May 3, 2024

metamaskbot commented May 7, 2024

codecov bot commented May 7, 2024

Codecov Report

adonesky1 May 7, 2024

Choose a reason for hiding this comment

adonesky1 May 7, 2024

Choose a reason for hiding this comment

metamaskbot commented May 23, 2024