fix: lint violations maskicon #680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -65,9 +62,6 @@ const config = createConfig([ | |||
| 'packages/design-system-react-native/src/components/temp-components/ImageOrSvg/ImageOrSvg.stories.tsx', | |||
| 'packages/design-system-react-native/src/components/temp-components/ImageOrSvg/ImageOrSvg.test.tsx', | |||
| 'packages/design-system-react-native/src/components/temp-components/ImageOrSvg/ImageOrSvg.tsx', | |||
| 'packages/design-system-react-native/src/components/temp-components/Maskicon/Maskicon.test.tsx', | |||
| 'packages/design-system-react-native/src/components/temp-components/Maskicon/Maskicon.tsx', | |||
| 'packages/design-system-react-native/src/components/temp-components/Maskicon/Maskicon.utilities.ts', | |||
| 'packages/design-system-react-native/src/components/temp-components/Spinner/Spinner.tsx', | |||
There was a problem hiding this comment.
Removing maskicon components from file ignore list in eslint config
| @@ -31,6 +31,7 @@ module.exports = merge(baseConfig, { | |||
| '!**/*.dev.{js,ts}', // Exclude .dev files | |||
| '!**/*.assets.{js,ts}', // Exclude .assets files | |||
| '!**/*.types.{js,ts}', // Exclude .types files | |||
| '!./src/components/temp-components/Blockies/Blockies.utilities.d.ts', | |||
There was a problem hiding this comment.
Resolves this testing issue for new recent types file for blockies utilities
georgewrmarshall
force-pushed
the
fix/lint-violiations-maskicon
branch
from
77c4431 to
9270213
Compare
georgewrmarshall
force-pushed
the
fix/lint-violiations-maskicon
branch
from
9270213 to
d0943c5
Compare
brianacnguyen
approved these changes
May 22, 2025
📖 Storybook Preview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes linting violations in the Maskicon component across both React and React Native versions of the design system. The changes are focused on addressing various ESLint warnings and following best practices to ensure code consistency.
Key improvements include:
toStrictEqual()instead oftoEqual()voidRelated issues
Part of:
Manual testing steps
yarn lintto verify linting violations are fixedyarn test Maskiconyarn buildScreenshots/Recordings
React Native
React
Pre-merge author checklist