Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace null with intentionally-skip in release-spec template comment #99

Merged

Conversation

legobeat
Copy link
Contributor

Alternative to #92 to make the current behavior more immediately obvious and the comment more helpful.

@legobeat legobeat requested a review from a team as a code owner September 13, 2023 00:42
@legobeat legobeat force-pushed the fix-intentionally-skip-in-spec-template branch from d160d2e to 4aeb19a Compare September 13, 2023 00:44
@legobeat legobeat force-pushed the fix-intentionally-skip-in-spec-template branch from 4aeb19a to cf98489 Compare September 13, 2023 01:21
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legobeat legobeat merged commit 73f60d0 into MetaMask:main Sep 13, 2023
19 of 21 checks passed
@legobeat legobeat deleted the fix-intentionally-skip-in-spec-template branch September 13, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants