feat: add `SEI` network support in `@metamask/assets-controllers` #5610

stanleyyconsensys · 2025-04-08T04:20:48Z

Explanation

This PR is to adding SEI support for

Assets Controller

Even if the network is not yet onboard on mobile/extension
it has no harm to adding SEI support on mobile/extension

References

Changelog

Checklist

I've updated the test suite for new or updated code as appropriate
I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

stanleyyconsensys · 2025-04-16T10:13:36Z

@metamaskbot publish-preview

stanleyyconsensys · 2025-04-17T02:01:26Z

@metamaskbot publish-preview

github-actions · 2025-04-17T02:06:48Z

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.

{
  "@metamask-previews/accounts-controller": "27.0.0-preview-fa52096c",
  "@metamask-previews/address-book-controller": "6.0.3-preview-fa52096c",
  "@metamask-previews/announcement-controller": "7.0.3-preview-fa52096c",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-fa52096c",
  "@metamask-previews/approval-controller": "7.1.3-preview-fa52096c",
  "@metamask-previews/assets-controllers": "56.0.0-preview-fa52096c",
  "@metamask-previews/base-controller": "8.0.0-preview-fa52096c",
  "@metamask-previews/bridge-controller": "14.0.0-preview-fa52096c",
  "@metamask-previews/bridge-status-controller": "12.0.1-preview-fa52096c",
  "@metamask-previews/build-utils": "3.0.3-preview-fa52096c",
  "@metamask-previews/chain-agnostic-permission": "0.3.0-preview-fa52096c",
  "@metamask-previews/composable-controller": "11.0.0-preview-fa52096c",
  "@metamask-previews/controller-utils": "11.7.0-preview-fa52096c",
  "@metamask-previews/delegation-controller": "0.0.0-preview-fa52096c",
  "@metamask-previews/earn-controller": "0.11.0-preview-fa52096c",
  "@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-fa52096c",
  "@metamask-previews/ens-controller": "16.0.0-preview-fa52096c",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-fa52096c",
  "@metamask-previews/gas-fee-controller": "23.0.0-preview-fa52096c",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-fa52096c",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-fa52096c",
  "@metamask-previews/keyring-controller": "21.0.2-preview-fa52096c",
  "@metamask-previews/logging-controller": "6.0.4-preview-fa52096c",
  "@metamask-previews/message-manager": "12.0.1-preview-fa52096c",
  "@metamask-previews/multichain": "4.0.0-preview-fa52096c",
  "@metamask-previews/multichain-api-middleware": "0.1.1-preview-fa52096c",
  "@metamask-previews/multichain-network-controller": "0.4.0-preview-fa52096c",
  "@metamask-previews/multichain-transactions-controller": "0.9.0-preview-fa52096c",
  "@metamask-previews/name-controller": "8.0.3-preview-fa52096c",
  "@metamask-previews/network-controller": "23.2.0-preview-fa52096c",
  "@metamask-previews/notification-services-controller": "6.0.0-preview-fa52096c",
  "@metamask-previews/permission-controller": "11.0.6-preview-fa52096c",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-fa52096c",
  "@metamask-previews/phishing-controller": "12.4.1-preview-fa52096c",
  "@metamask-previews/polling-controller": "13.0.0-preview-fa52096c",
  "@metamask-previews/preferences-controller": "17.0.0-preview-fa52096c",
  "@metamask-previews/profile-sync-controller": "12.0.0-preview-fa52096c",
  "@metamask-previews/queued-request-controller": "10.0.0-preview-fa52096c",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-fa52096c",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-fa52096c",
  "@metamask-previews/sample-controllers": "0.1.0-preview-fa52096c",
  "@metamask-previews/selected-network-controller": "22.0.0-preview-fa52096c",
  "@metamask-previews/signature-controller": "27.1.0-preview-fa52096c",
  "@metamask-previews/token-search-discovery-controller": "3.1.0-preview-fa52096c",
  "@metamask-previews/transaction-controller": "54.1.0-preview-fa52096c",
  "@metamask-previews/user-operation-controller": "33.0.0-preview-fa52096c"
}

cryptodev-2s

LGTM!

cryptodev-2s · 2025-04-17T09:30:41Z

@stanleyyconsensys you’ve got some conflicts to resolve—let me know once they’re fixed and I’ll take another look.

stanleyyconsensys · 2025-04-17T09:46:38Z

@stanleyyconsensys you’ve got some conflicts to resolve—let me know once they’re fixed and I’ll take another look.

@cryptodev-2s thanks for the review, just resolve the conflict on the change log, hopefully it will not happen again

i just wonder why we change the way for implement the change log, previous one seem better (at least you wont have conflict on that?)

packages/transaction-controller/CHANGELOG.md

packages/bridge-controller/CHANGELOG.md

packages/assets-controllers/CHANGELOG.md

cryptodev-2s

LGTM!

packages/assets-controllers/CHANGELOG.md

salimtb

assets changes lgtm

packages/assets-controllers/CHANGELOG.md

sahar-fehri · 2025-04-17T12:25:23Z

Oh i think this line in changelog got lost

Add SEI network support (#5610)

packages/transaction-controller/src/helpers/AccountsApiRemoteTransactionSource.ts

packages/transaction-controller/src/constants.ts

packages/transaction-controller/src/api/accounts-api.ts

mcmire · 2025-04-17T12:40:17Z

@stanleyyconsensys Do we need to update controller-utils as well?

OGPoyraz

Lifting off my RC since we rolled back transaction-controller changes

stanleyyconsensys · 2025-04-17T12:51:56Z

@stanleyyconsensys Do we need to update controller-utils as well?

@mcmire SEI is not a build-in network, it is a feature network like Polygon, so we dont need to update controller-utils

im thinking, we should create a refactor PR to remove all the chainIDs from any controller,
and having them to pass in from Constructor

else it will become a super annoying whenever we need to add a network , wdyt?

cryptodev-2s

LGTM!

amitabh94 · 2025-04-17T17:45:09Z

packages/bridge-controller/src/constants/bridge.ts

@@ -17,6 +17,7 @@ export const ALLOWED_BRIDGE_CHAIN_IDS = [
  CHAIN_IDS.ARBITRUM,
  CHAIN_IDS.LINEA_MAINNET,
  CHAIN_IDS.BASE,
+  CHAIN_IDS.SEI,


@ejwessel @micaelae Are we supporting bridge quotes for SEI network ?

@amitabh94 it is not supported for now, but it is wip by ME

since the UI is blocking the user to fetch quote for SEI, so i think it is okay to add the chain id here

due to the sake of simplicity on the review of this PR, i remove bridge controller to avoid blocking the others

mikesposito

LGTM!

sahar-fehri · 2025-04-22T09:22:25Z

packages/assets-controllers/CHANGELOG.md

- Added `fetchHistoricalPricesForAsset` method to `MultichainAssetsRatesController` ([#5639](https://github.com/MetaMask/core/pull/5639))
- Added `getSelectedMultichainAccount` action to `multichainAssetsRatesController` ([#5639](https://github.com/MetaMask/core/pull/5639))
- Added new state field `historicalPrices` to `MultichainAssetsRatesController` ([#5639](https://github.com/MetaMask/core/pull/5639))
+- Add `includeMarketData` to the params of the `OnAssetsConversion` handler ([#5639](https://github.com/MetaMask/core/pull/5639))


v58 has been already released; is this change intentional?

um, as i had a comment from @cryptodev-2s previously

which we should use Add instead of Added

i can rollback that, but just for align purpose

@sahar-fehri which way we prefer

just change to Add for this PR
or do it for previous too
or use Added

Since it has been already released, lets not update it; but in future we use Add

stanleyyconsensys added 5 commits April 8, 2025 12:20

chore: add sei network for general support

6d98d3e

chore: add sei network for bridge & swap support

1a9f113

Merge branch 'main' into feat/add-sei-network-support

f7866de

chore: add sei symbol

809505b

chore: lint

fa52096

stanleyyconsensys added 2 commits April 17, 2025 11:32

chore: add change log

d7f2460

Merge branch 'main' into feat/add-sei-network-support

7b2c95e

stanleyyconsensys marked this pull request as ready for review April 17, 2025 03:36

stanleyyconsensys requested review from a team as code owners April 17, 2025 03:36

stanleyyconsensys added 2 commits April 17, 2025 11:39

chore: update sei display name

457f175

Merge branch 'main' into feat/add-sei-network-support

6d62172

cryptodev-2s previously approved these changes Apr 17, 2025

View reviewed changes

Merge branch 'main' into feat/add-sei-network-support

3887da0

stanleyyconsensys dismissed cryptodev-2s’s stale review via 3887da0 April 17, 2025 09:45

cryptodev-2s reviewed Apr 17, 2025

View reviewed changes

packages/transaction-controller/CHANGELOG.md Outdated Show resolved Hide resolved

cryptodev-2s reviewed Apr 17, 2025

View reviewed changes

packages/bridge-controller/CHANGELOG.md Outdated Show resolved Hide resolved

cryptodev-2s reviewed Apr 17, 2025

View reviewed changes

packages/assets-controllers/CHANGELOG.md Outdated Show resolved Hide resolved

chore: update change log

364dde3

stanleyyconsensys requested a review from cryptodev-2s April 17, 2025 10:10

cryptodev-2s previously approved these changes Apr 17, 2025

View reviewed changes

sahar-fehri reviewed Apr 17, 2025

View reviewed changes

packages/assets-controllers/CHANGELOG.md Show resolved Hide resolved

Merge branch 'main' into feat/add-sei-network-support

55efb82

wantedsystem previously approved these changes Apr 17, 2025

View reviewed changes

salimtb previously approved these changes Apr 17, 2025

View reviewed changes

cryptodev-2s reviewed Apr 17, 2025

View reviewed changes

packages/assets-controllers/CHANGELOG.md Outdated Show resolved Hide resolved

chore: update change log

ba6884a

stanleyyconsensys dismissed stale reviews from salimtb and wantedsystem via ba6884a April 17, 2025 12:28

OGPoyraz requested changes Apr 17, 2025

View reviewed changes

packages/transaction-controller/src/helpers/AccountsApiRemoteTransactionSource.ts Outdated Show resolved Hide resolved

packages/transaction-controller/src/constants.ts Outdated Show resolved Hide resolved

OGPoyraz reviewed Apr 17, 2025

View reviewed changes

packages/transaction-controller/src/api/accounts-api.ts Outdated Show resolved Hide resolved

chore: revert tx controller change

908943b

OGPoyraz reviewed Apr 17, 2025

View reviewed changes

OGPoyraz previously approved these changes Apr 17, 2025

View reviewed changes

cryptodev-2s previously approved these changes Apr 17, 2025

View reviewed changes

sahar-fehri previously approved these changes Apr 17, 2025

View reviewed changes

stanleyyconsensys enabled auto-merge (squash) April 17, 2025 14:26

amitabh94 reviewed Apr 17, 2025

View reviewed changes

stanleyyconsensys changed the title ~~feat: add SEI network support~~ feat: add SEI network support in Assets Controller Apr 22, 2025

chore: rollback bridge controller

292e13d

stanleyyconsensys dismissed stale reviews from sahar-fehri, cryptodev-2s, and OGPoyraz via 292e13d April 22, 2025 04:14

chore: rollback bridge controller

b90d309

stanleyyconsensys changed the title ~~feat: add SEI network support in Assets Controller~~ feat: add SEI network support in @metamask/assets-controllers Apr 22, 2025

stanleyyconsensys added 3 commits April 22, 2025 16:49

fix: lint

c50d761

chore: change log lint

b97f550

chore: lint

3ac653f

mikesposito approved these changes Apr 22, 2025

View reviewed changes

sahar-fehri reviewed Apr 22, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add `SEI` network support in `@metamask/assets-controllers` #5610

feat: add `SEI` network support in `@metamask/assets-controllers` #5610

stanleyyconsensys commented Apr 8, 2025 •

edited

Loading

stanleyyconsensys commented Apr 16, 2025

stanleyyconsensys commented Apr 17, 2025

github-actions bot commented Apr 17, 2025

cryptodev-2s left a comment

cryptodev-2s commented Apr 17, 2025

stanleyyconsensys commented Apr 17, 2025 •

edited

Loading

cryptodev-2s left a comment

salimtb left a comment

sahar-fehri commented Apr 17, 2025

mcmire commented Apr 17, 2025

OGPoyraz left a comment

stanleyyconsensys commented Apr 17, 2025 •

edited

Loading

cryptodev-2s left a comment

amitabh94 Apr 17, 2025

stanleyyconsensys Apr 18, 2025 •

edited

Loading

stanleyyconsensys Apr 22, 2025

mikesposito left a comment

sahar-fehri Apr 22, 2025

stanleyyconsensys Apr 22, 2025 •

edited

Loading

stanleyyconsensys Apr 22, 2025 •

edited

Loading

sahar-fehri Apr 22, 2025

feat: add SEI network support in @metamask/assets-controllers #5610

Are you sure you want to change the base?

feat: add SEI network support in @metamask/assets-controllers #5610

Conversation

stanleyyconsensys commented Apr 8, 2025 • edited Loading

Explanation

References

Changelog

Checklist

stanleyyconsensys commented Apr 16, 2025

stanleyyconsensys commented Apr 17, 2025

github-actions bot commented Apr 17, 2025

cryptodev-2s left a comment

Choose a reason for hiding this comment

cryptodev-2s commented Apr 17, 2025

stanleyyconsensys commented Apr 17, 2025 • edited Loading

cryptodev-2s left a comment

Choose a reason for hiding this comment

salimtb left a comment

Choose a reason for hiding this comment

sahar-fehri commented Apr 17, 2025

mcmire commented Apr 17, 2025

OGPoyraz left a comment

Choose a reason for hiding this comment

stanleyyconsensys commented Apr 17, 2025 • edited Loading

cryptodev-2s left a comment

Choose a reason for hiding this comment

amitabh94 Apr 17, 2025

Choose a reason for hiding this comment

stanleyyconsensys Apr 18, 2025 • edited Loading

Choose a reason for hiding this comment

stanleyyconsensys Apr 22, 2025

Choose a reason for hiding this comment

mikesposito left a comment

Choose a reason for hiding this comment

sahar-fehri Apr 22, 2025

Choose a reason for hiding this comment

stanleyyconsensys Apr 22, 2025 • edited Loading

Choose a reason for hiding this comment

stanleyyconsensys Apr 22, 2025 • edited Loading

Choose a reason for hiding this comment

sahar-fehri Apr 22, 2025

Choose a reason for hiding this comment

feat: add `SEI` network support in `@metamask/assets-controllers` #5610

feat: add `SEI` network support in `@metamask/assets-controllers` #5610

stanleyyconsensys commented Apr 8, 2025 •

edited

Loading

stanleyyconsensys commented Apr 17, 2025 •

edited

Loading

stanleyyconsensys commented Apr 17, 2025 •

edited

Loading

stanleyyconsensys Apr 18, 2025 •

edited

Loading

stanleyyconsensys Apr 22, 2025 •

edited

Loading

stanleyyconsensys Apr 22, 2025 •

edited

Loading