user mode systemd unit, with co-ordinated cgroups. #1463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add option setting cgroupOverride, example usage: cgroupOverride /sys/fs/cgroup/user.slice/user-1000.slice/[email protected]/app.slice/metpx-sr3.service this means that when sr3 starts up a process, either by analyst intervention or sr3 sanity, it will add the processes launched to this cgroup. systemD uses this group, so when starting up entire thing with systemD it will see what is already running. so systemD view and sr3 view of which processes are running should be consistent now. otoh... if systemd things the unit is stopped, it does not look at the cgroup, so it will not see things running if they are started manually. once it is started though, it does see the ones manually started before. ~ ~
Test Results243 tests 242 ✅ 1m 40s ⏱️ Results for commit 5f3f32f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1461
This is option 1 discussed in #1461. I don't think it should be merged... just want it to sit here for people to try out.
and think about. I want this PR to be in draft state an not get merged... for a month or two at least.
Add option setting cgroupOverride, example usage:
cgroupOverride /sys/fs/cgroup/user.slice/user-1000.slice/[email protected]/app.slice/metpx-sr3.service
this means that when sr3 starts up a process, either by analyst intervention or sr3 sanity, it will add the processes launched to this cgroup. systemD uses this group, so when starting up entire thing with systemD it will see what is already running. so systemD view and sr3 view of which processes are running should be consistent now.
otoh... if systemd things the unit is stopped, it does not look at the cgroup, so it will not see things running if they are started manually. once it is started though, it does see the ones manually started before.
~
~