Add recursion back #1237
Merged
Add recursion back #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results249 tests 246 ✅ 1m 30s ⏱️ For more details on these failures, see this check. Results for commit 6c77c29. |
reidsunderland
approved these changes
Oct 7, 2024
andreleblanc11
approved these changes
Oct 7, 2024
|
I tested with a poll and it works! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just looked at the code and guessed where it needs to be added back.
There is one patch to add it to watch, one to document, and one to add it to poll.
I ran the flow tests and they pass as well as before.
Have not actually tested what happens when you turn recursive off. someone perhaps should before merging this.
It's harmless, but I don't know if it does what it should.