Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(mergify): upgrade conf to use MP #6144

Conversation

jd
Copy link
Member

@jd jd commented Mar 5, 2025

This implements a few changes:

  • leverage MP to check for CI
  • leverage MP to check for review requirements

@jd
Copy link
Member Author

jd commented Mar 5, 2025

This pull request is part of a stack:

  1. ci(mergify): upgrade conf to use MP (#6144) 👈
  2. ci(mergify): implement priority rules (#6145)

Copy link
Contributor

mergify bot commented Mar 5, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 🤖 Continuous Integration

Wonderful, this rule succeeded.
  • all of:
    • check-success = lint
    • check-success = test
    • any of:
      • check-success = test-broken-links
      • label = ignore-broken-links
    • any of:
      • check-success=Cloudflare Pages
      • -head-repo-full-name~=^Mergifyio/

🟢 👀 Review Requirements

Wonderful, this rule succeeded.
  • any of:
    • #approved-reviews-by >= 2
    • author = dependabot[bot]
    • author = mergify-ci-bot

🟢 Changelog requirements

Wonderful, this rule succeeded.
  • any of:
    • -title ~= ^feat
    • label = need changelog
    • label = skip changelog

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 🔎 Reviews

Wonderful, this rule succeeded.
  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

@mergify mergify bot requested a review from a team March 5, 2025 08:09
Copy link
Contributor

@DouglasBlackwood DouglasBlackwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need hotfix rules for the documentation?

sileht
sileht previously approved these changes Mar 5, 2025
This implements a few changes:
- leverage MP to check for CI
- leverage MP to check for review requirements

Change-Id: Ie0cf04c506b7f2e2c92e49b2faa5f801b665b145
@jd jd force-pushed the devs/jd/simplify-conf/Ie0cf04c506b7f2e2c92e49b2faa5f801b665b145 branch from 583f0bb to 609774d Compare March 5, 2025 08:54
@jd
Copy link
Member Author

jd commented Mar 5, 2025

Do we really need hotfix rules for the documentation?

I thought about it, I'm not 100% sure but it's when you need it and you don't have it that you're unhappy. I think it's great to have this path of requiring a single approval if something's broken.

@mergify mergify bot dismissed stale reviews from DouglasBlackwood and sileht March 5, 2025 08:54

Pull request has been modified.

@mergify mergify bot requested a review from a team March 5, 2025 08:55
mergify bot added a commit that referenced this pull request Mar 5, 2025
@mergify mergify bot added the queued label Mar 5, 2025
@mergify mergify bot merged commit 0d5ab37 into main Mar 5, 2025
11 checks passed
@mergify mergify bot deleted the devs/jd/simplify-conf/Ie0cf04c506b7f2e2c92e49b2faa5f801b665b145 branch March 5, 2025 09:59
@mergify mergify bot removed the queued label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants