-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(mergify): upgrade conf to use MP #6144
ci(mergify): upgrade conf to use MP #6144
Conversation
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 🤖 Continuous IntegrationWonderful, this rule succeeded.
🟢 👀 Review RequirementsWonderful, this rule succeeded.
🟢 Changelog requirementsWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 ReviewsWonderful, this rule succeeded.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need hotfix rules for the documentation?
This implements a few changes: - leverage MP to check for CI - leverage MP to check for review requirements Change-Id: Ie0cf04c506b7f2e2c92e49b2faa5f801b665b145
583f0bb
to
609774d
Compare
I thought about it, I'm not 100% sure but it's when you need it and you don't have it that you're unhappy. I think it's great to have this path of requiring a single approval if something's broken. |
Pull request has been modified.
This implements a few changes: