test

[michaelhuang14]

This change is 

[michaelhuang14]

your code sucks. Please see my comments below for clarification. I'm inexperienced with Github, so I wasn't aware I was doing a pull request to the original repo. This is a big misunderstanding :(.

[MengeCrowdSim]

I'm always grateful for contributions from the community and look forward to perusing your proposed changes.

However, before examining your PR, I would call out your "Your code sucks" comment.

I harbor no illusions as to the weaknesses of Menge (both in features and architecture). It has its own unique history that contributes to that. However, it has proven useful to me and others and so I've released it, warts and all, for public consumption.

A statement like "Your code sucks" accomplishes nothing. It doesn't provide any insight beyond what I already knew. It doesn't discuss the flaws in a coherent manner. It certainly doesn't recommend solutions. In fact, I find it incredibly challenging to even infer positive intentions. Taken alone, it most readily reads as an insult. On the off chance that it wasn't intended as such, I'd invite you to clarify your statement to help me glean the intended value.

If, however, it was intended as an insult, I would strongly state that that form of interaction will not be tolerated. There is simply no place for that.

All that aside, I note from your history that you don't have much experience in contributing back to open source code repositories. I'm flattered that you want to contribute to Menge. However, I have the following thoughts:

• Large PRs get reviewed slowly (if at all). Yours is 2600 lines and it's difficult to fully evaluate such a large set of changes as it deserves. A good rule of thumb is to limit yourself to about 500-line PRs.
• A PR should represent a single coherent change. And that change should be documented in the commit(s) and, ideally, in the PR documentation. It's best if the reviewer doesn't have to guess what is being accomplished by the PR.
• A PR with multiple commits is generally not a good idea. Typically, multiple commits reflects the historical workflow, but isn't exactly the commit history that should live in master. Ideally, in master, any commit should be buildable and functional. If your PR includes intermediate work commits that aren't buildable or correct, that gets broken. If you feel multiple commits are correct and appropriate, a note in the submitted PR explaining that belief and its underpinnings would also be appropriate.
• Finally, please note that your PR has merge conflicts. I'd recommend rebasing it on the current version of master. (Obviously, that's not the only way to do it, it's simply that I've come to prefer a rebase over a merge operation.)

Again, thanks for contributing.

[chraibi]

your code sucks

🙄

[michaelhuang14]

Oh, I'm so so sorry. I didn't realize I had actually posted this comment on the original repo!!! I was working with a friend on developing a code review exercise for my lab, and I wrote that comment as a self deprecating joke for my own contribution! I'm very embarrassed and sorry for any bad feelings this might have caused!!

[michaelhuang14]

I also want to add that when I used the crowd simulator for my projects a few years ago, it was my first time working with code in the wild in a research setting, and helped influence my current interests, so I'm very grateful for that. :)

[MengeCrowdSim]

No worries at all. :) I had to assume that anyone who was going to try to push 2600 lines probably wasn't trying to torpedo their own effort.

That does cause me to wonder if you meant this PR for this repo, or your friend's fork. Either way, I can look at it and give some thoughts/feedback. I'd certainly like to steal as much of this as possible that improves Menge for all users. :D

[michaelhuang14]

Great! If you manage to make some use of my code, that would make me really happy. It has been a long time since I looked at this project, but I think most of my contributions were in creating a few simple new Actions, GoalSelectors, Transitions, etc. I was new to C++ at the time (and ROS+linux environments, which I was working in), so please excuse bad form or strange code if you come across it haha.