fix: pidIsAlive self-PID check for stale lock detection#2099
Open
34262315716 wants to merge 2 commits into
Open
fix: pidIsAlive self-PID check for stale lock detection#209934262315716 wants to merge 2 commits into
34262315716 wants to merge 2 commits into
Conversation
Memtensor-AI
requested review from
CarltonXiang,
MatthewZhuang,
World-controller and
syzsunshine219
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2098
Problem
When OpenClaw gateway exits abnormally, the openclaw-runtime.lock/ dir and owner.json remain on disk. On restart, if the OS reuses the same PID, pidIsAlive() signals itself and incorrectly reports duplicate runtime.
Fix
Added
if (pid === process.pid) return false;in pidIsAlive() to exclude self-PID from stale lock check. Zero side-effect: owner.pid can only equal process.pid when the lock is from a previous lifecycle of the same process.Files changed