Backport 2.28: ssl-opt.sh, compat.sh: Error out if not executing any tests #9204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alert if all tests are filtered out or skipped: that probably indicates a test script that set up an unintended configuration or an overly strict filter. You can pass `--min 0` to bypass this check. You can pass `--min` with a larger value to require that many test cases to run. Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
added
needs-review
paul-elliott-arm
previously approved these changes
May 29, 2024
|
It seems the change revealed an issue in |
4 tasks
gilles-peskine-arm
added
needs-work
and removed
needs-review
|
@ronald-cron-arm Yes, there's a |
With GnuTLS servers, 3DES-CBC cipher suites are enabled by default under our GNUTLS_LEGACY (3.3.8), but disabled by default under more recent versions including the one we use by default on the CI (3.4.6). Even modern versions (I checked 3.7.2) support 3DES if explicitly enabled. So unconditionally enable 3DES-CBC for GnuTLS. Signed-off-by: Gilles Peskine <[email protected]>
We were only requesting 3DES cipher suites (which is weirdly restrictive since the configuration also includes AES), but DES is in the default exclusion list for compat.sh, so we ended up having no acceptable cipher suites. Fix this. Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
added
needs-review
| @@ -27,7 +27,8 @@ | |||
| 'test_again_with_use_psa' => 1 | |||
| }, | |||
There was a problem hiding this comment.
I checked what compat.sh test cases we're running for each configuration here, and I think there are more omissions than the one I fixed, but for the other configurations we're running at least one test case so the CI is passing now:
- The CCM-PSK configurations aren't testing OpenSSL interoperability, but that's a broader problem.
- For suite-b, we aren't doing GnuTLS or OpenSSL interoperability. It's deliberate but I don't know why. Both GnuTLS and OpenSSL interop fail, which I've filed as a separate issue.
ronald-cron-arm
requested changes
May 31, 2024
Filtering on cipher suites that have RSA in their name excludes a few old RSA-based cipher suites whose name doesn't contain RSA. Signed-off-by: Gilles Peskine <[email protected]>
|
@paul-elliott-arm please have a look to the last version, thanks. |
paul-elliott-arm
approved these changes
Jun 7, 2024
paul-elliott-arm
added
the
approved
gilles-peskine-arm
removed
the
needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #9149, and fix some 2.28-only issues that it reveals.
PR checklist