fix typo #9155
Merged
fix typo #9155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Turiiya <[email protected]>
| @@ -328,7 +328,7 @@ def __str__(self): | |||
| {translation_table} | |||
| }}; | |||
|
|
|||
| return "UNKOWN"; | |||
| return "UNKNOWN"; | |||
There was a problem hiding this comment.
This was previously fixed in #5732 at https://github.com/Mbed-TLS/mbedtls/pull/5732/files#diff-c1d4f10f0fef89231d91756c0b67ee38bcbed022a4b80f0ea3b44fb4c0e4b845R292, so how come it's wrong in-tree?
There was a problem hiding this comment.
47854e6 reverted return "UNKOWN_VAULE"; to the return with the oopsi.
There was a problem hiding this comment.
Ah yes, but for "UNKOWN" we only fixed one of two instances in the file back in #5732 - there is so much duplicated template around this line that it wasn't obvious to me yesterday evening
minosgalanakis
added
component-test
|
Thanks for your contribution. Could you please backport this PR against mbedtls-3.6 branch? |
gilles-peskine-arm
added
the
needs-review
gilles-peskine-arm
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please write a few sentences describing the overall goals of the pull request's commits.
PR checklist
Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")
Notes for the submitter
Please refer to the contributing guidelines, especially the
checklist for PR contributors.
Help make review efficient: