Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace MBEDTLS_MD_CAN_MD5 with PSA_WANT_ALG_MD5 #9123

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Replace MBEDTLS_MD_CAN_MD5 with PSA_WANT_ALG_MD5 #9123

merged 1 commit into from
Jul 18, 2024

Conversation

eleuzi01
Copy link
Contributor

@eleuzi01 eleuzi01 commented May 10, 2024 •
edited by gilles-peskine-arm
Loading

Description

Issue #9110.

Status: blocked by #9290 which fixes dependencies around a use of MD5 in test code.

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

  • changelog not required, internal changes
  • 3.6 backport not required, needed for 4.0
  • 2.28 backport not required, needed for 4.0
  • tests not required

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

Help make review efficient:

  • Multiple simple commits
    • please structure your PR into a series of small commits, each of which does one thing
  • Avoid force-push
    • please do not force-push to update your PR - just add new commit(s)
  • See our Guidelines for Contributors for more details about the review process.

@eleuzi01 eleuzi01 self-assigned this May 10, 2024
@tom-daubney-arm tom-daubney-arm added enhancement component-crypto Crypto primitives and low-level interfaces labels May 15, 2024
@gabor-mezei-arm gabor-mezei-arm linked an issue May 21, 2024 that may be closed by this pull request
Replace MBEDTLS_MD_CAN_MD5 and MBEDTLS_MD_CAN_RIPEMD160 macros with its PSA_WANT counterpartarts #9110
Closed
@eleuzi01 eleuzi01 added the size-xs Estimated task size: extra small (a few hours at most) label May 31, 2024
@gabor-mezei-arm gabor-mezei-arm added the needs-preceding-pr Requires another PR to be merged first label Jun 5, 2024
@eleuzi01 eleuzi01 added needs-ci Needs to pass CI tests priority-high High priority - will be reviewed soon labels Jun 13, 2024
@eleuzi01 eleuzi01 added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review and removed needs-preceding-pr Requires another PR to be merged first labels Jun 20, 2024
@gabor-mezei-arm gabor-mezei-arm self-requested a review June 20, 2024 16:02
@eleuzi01 eleuzi01 removed the needs-ci Needs to pass CI tests label Jun 24, 2024
gabor-mezei-arm
gabor-mezei-arm previously approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@gabor-mezei-arm gabor-mezei-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
The CI is failing after all test have been passed.

@tom-daubney-arm
Copy link
Contributor

Note that this issue is only half of the fix for #9110. We will need #9125 to be merged as well before we can close this issue.

@tom-daubney-arm tom-daubney-arm self-requested a review July 2, 2024 18:53
@tom-daubney-arm tom-daubney-arm removed the needs-reviewer This PR needs someone to pick it up for review label Jul 2, 2024
tom-daubney-arm
tom-daubney-arm previously approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@tom-daubney-arm tom-daubney-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

Only remaining hits for MBEDTLS_MD_CAN_MD5 are in the include directory and the description in #9110 says that it is not required to remove from there.

Question though: Why not just remove these hits from check_config.h and config_adjust_legacy_crypto.h? Are they being removed later? @eleuzi01 @gabor-mezei-arm

@tom-daubney-arm tom-daubney-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Jul 2, 2024
@tom-daubney-arm
Copy link
Contributor

LGTM The CI is failing after all test have been passed.

Given this comment, I am ignoring the CI failures.

@gabor-mezei-arm
Copy link
Contributor

Question though: Why not just remove these hits from check_config.h and config_adjust_legacy_crypto.h? Are they being removed later?

It will be removed later.

@gilles-peskine-arm gilles-peskine-arm added needs-ci Needs to pass CI tests needs-work and removed approved Design and code approved - may be waiting for CI or backports labels Jul 3, 2024
@gilles-peskine-arm
Copy link
Contributor

There is now a genuine CI failure in outcome analysis, see the logs.

It will be fixed by #9290. I suggest waiting until that is merged.

@gilles-peskine-arm gilles-peskine-arm added the needs-preceding-pr Requires another PR to be merged first label Jul 4, 2024
@eleuzi01 eleuzi01 added needs-review Every commit must be reviewed by at least two team members, and removed needs-work needs-preceding-pr Requires another PR to be merged first labels Jul 18, 2024
gabor-mezei-arm
gabor-mezei-arm approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@gabor-mezei-arm gabor-mezei-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tom-daubney-arm
tom-daubney-arm approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@tom-daubney-arm tom-daubney-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@tom-daubney-arm tom-daubney-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests labels Jul 18, 2024
@bensze01 bensze01 added this pull request to the merge queue Jul 18, 2024
Merged via the queue into Mbed-TLS:development with commit e7fdfdb Jul 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabor-mezei-arm gabor-mezei-arm gabor-mezei-arm approved these changes

@tom-daubney-arm tom-daubney-arm tom-daubney-arm approved these changes

Assignees

@eleuzi01 eleuzi01

Labels
approved Design and code approved - may be waiting for CI or backports component-crypto Crypto primitives and low-level interfaces enhancement priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most)
Projects
Roadmap Board for Mbed TLS
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace MBEDTLS_MD_CAN_MD5 and MBEDTLS_MD_CAN_RIPEMD160 macros with its PSA_WANT counterpartarts
5 participants
@eleuzi01 @tom-daubney-arm @gabor-mezei-arm @gilles-peskine-arm @bensze01