Check union initialization portably #10178
Open
+3
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gilles Peskine <[email protected]>
This is a non-regression test for Mbed-TLS#9814 Signed-off-by: Gilles Peskine <[email protected]>
Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
added
the
component-crypto
gilles-peskine-arm
added
needs-ci
github-project-automation
bot
moved this to In Development
in Roadmap pull requests (new board)
This was referenced May 15, 2025
gilles-peskine-arm
added
the
needs-backports
This was referenced May 15, 2025
mpg
reviewed
Jun 4, 2025
mpg
reviewed
Jun 4, 2025
| # disable the new problematic optimization. | ||
| loc_cflags="${loc_cflags} -fzero-init-padding-bits=unions" | ||
| # Also allow a warning that we don't yet comply to. | ||
| # Allow a warning that we don't yet comply to. |
There was a problem hiding this comment.
Actually, looking at current development if looks like this change was already done. I'm surprised github doesn't show it as a conflict. But overall I'm not sure we really need this PR, considering the only changes it's doing are either already done, or submodule updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved testing for #9814 and #9975. This PR just combines the bits and may not be needed if all submodules get updated through alternative PR.
Needs preceding PR:
PR checklist