-
Notifications
You must be signed in to change notification settings - Fork 1
Initial Release #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
==========================================
- Coverage 94.11% 92.52% -1.60%
==========================================
Files 6 6
Lines 85 107 +22
Branches 13 20 +7
==========================================
+ Hits 80 99 +19
- Misses 5 6 +1
- Partials 0 2 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments regarding the current README.
Otherwise looks great! Thanks for all that amazing work 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would second the changes requested by Eileen and have nothing to add.
Thanks for taking a look. I should have all the comments covered now; added an issue for documenting the version scheme. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, go for it 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot. Ready to merge!
This PR prepares the repo for the initial release. Notable changes include:
README.md
is suitable as a pypi descriptionindex.rst
is suitable as a RTD landing pageSince this is the initial release, I will manually trigger a release when this PR is merged.