Skip to content

Initial Release #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 21, 2022
Merged

Initial Release #2

merged 11 commits into from
Jun 21, 2022

Conversation

maxfischer2781
Copy link
Member

@maxfischer2781 maxfischer2781 commented May 30, 2022

This PR prepares the repo for the initial release. Notable changes include:

  • Added test setup for YAML plugins and applied it to all existing plugins
  • Proper version number matching the COBalD version scheme
  • Expanded docs to be release-ready
    • README.md is suitable as a pypi description
    • index.rst is suitable as a RTD landing page
  • Removed PyPy unittests since a secondary dependency does not support it

Since this is the initial release, I will manually trigger a release when this PR is merged.

@maxfischer2781 maxfischer2781 added this to the Initial release milestone May 30, 2022
@maxfischer2781 maxfischer2781 self-assigned this May 30, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 30, 2022

Codecov Report

Merging #2 (9f3fabf) into master (dee811f) will decrease coverage by 1.59%.
The diff coverage is 88.46%.

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
- Coverage   94.11%   92.52%   -1.60%     
==========================================
  Files           6        6              
  Lines          85      107      +22     
  Branches       13       20       +7     
==========================================
+ Hits           80       99      +19     
- Misses          5        6       +1     
- Partials        0        2       +2     
Impacted Files Coverage Δ
tests/utility.py 87.50% <81.25%> (-12.50%) ⬇️
cobald_hep_plugins/__init__.py 100.00% <100.00%> (ø)
cobald_hep_plugins/example.py 100.00% <100.00%> (ø)
tests/test_example.py 100.00% <100.00%> (ø)
tests/test_stopper.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dee811f...9f3fabf. Read the comment docs.

@maxfischer2781 maxfischer2781 marked this pull request as ready for review June 2, 2022 09:40
@maxfischer2781 maxfischer2781 requested review from eileen-kuehn, a team and giffels and removed request for a team June 2, 2022 09:40
Copy link
Member

@eileen-kuehn eileen-kuehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments regarding the current README.
Otherwise looks great! Thanks for all that amazing work 🚀

Copy link
Member

@giffels giffels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would second the changes requested by Eileen and have nothing to add.

@maxfischer2781
Copy link
Member Author

Thanks for taking a look. I should have all the comments covered now; added an issue for documenting the version scheme.

Copy link
Member

@eileen-kuehn eileen-kuehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, go for it 🚀

Copy link
Member

@giffels giffels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. Ready to merge!

@maxfischer2781 maxfischer2781 merged commit 6d2cc78 into master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants