Skip to content

Fix leftover linting errors #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CDeltakai merged 4 commits into from
May 16, 2025
Merged

Fix leftover linting errors #45

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8dc2e39
fix: removing unnecessary eslint disable comments
CDeltakai May 15, 2025
5c8bd8e
fix: intentionally discarding returned values with void as we are onl…
CDeltakai May 15, 2025
1ce7168
Fix: Replaced the blanket Function type with AnyFn = (...args: unknow…
CDeltakai May 16, 2025
8cafbe7
feat: added AnyFn type to types.ts to replace repeated usage
CDeltakai May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/CreateDestroy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,8 @@ function ready(
} else if (descriptor.set != null) {
kind = 'set';
}
const f: Function = descriptor[kind];
type AnyFn = (...args: Array<unknown>) => unknown;
const f = descriptor[kind] as AnyFn;
if (typeof f !== 'function') {
throw new TypeError(`${key} is not a function`);
}
Expand Down
3 changes: 2 additions & 1 deletion src/CreateDestroyStartStop.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,8 @@ function ready(
} else if (descriptor.set != null) {
kind = 'set';
}
const f: Function = descriptor[kind];
type AnyFn = (...args: Array<unknown>) => unknown;
const f = descriptor[kind] as AnyFn;
if (typeof f !== 'function') {
throw new TypeError(`${key} is not a function`);
}
Expand Down
3 changes: 2 additions & 1 deletion src/StartStop.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,8 @@ function ready(
} else if (descriptor.set != null) {
kind = 'set';
}
const f: Function = descriptor[kind];
type AnyFn = (...args: Array<unknown>) => unknown;
const f = descriptor[kind] as AnyFn;
if (typeof f !== 'function') {
throw new TypeError(`${key} is not a function`);
}
Expand Down
5 changes: 4 additions & 1 deletion src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,10 @@ function promise<T = void>(): PromiseDeconstructed<T> {
* This function rewrites the stack trace according to where the wrapped
* function is called, giving a more useful stack trace
*/
function resetStackTrace(error: Error, decorated?: Function): void {
function resetStackTrace(
error: Error,
decorated?: (...args: Array<unknown>) => unknown,
): void {
if (error.stack != null) {
const stackTitle = error.stack.slice(0, error.stack.indexOf('\n') + 1);
if (hasCaptureStackTrace) {
Expand Down