-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mirror implementation of new database system from main Skript plugin #96
Open
TheJoshue
wants to merge
29
commits into
Matocolotoe:master
Choose a base branch
from
TheJoshue:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simply mirrored implementation of new database system which works perfectly (but requires thorough/long-term testing) on main Skript repo at https://github.com/SkriptLang/Skript/tree/enhancement/sql or to be precise - https://github.com/SkriptLang/Skript/actions?page=3&query=branch%3Aenhancement%2Fsql - at these builds
After some time of testing things around with this, i can confirm that this runs stable, feel free to try it yourself (anyone who is reading this/curious), builds can be found at
Actions
in my fork.*
Note1: All 1.8 forks used for testing are forks that are not so different from paper but updated to latest libraries (log4j/netty/mysql) and similar stuff which should natively be inside of paper 1.8 even before it was abandoned, nothing more than making server slightly better environment to handle players with less lag (potentially).*
Note2: I apologize for the commit names, we had forked 2 times Skript-1.8 repo and needed to delete it both time after making a lot of changes inside... so we were tired to even type proper name... apologizes, we'll try to edit if it's possible.Thank you for reading, hope this PR gets accepted and merged into master branch and continued to be part of Skript-1.8 upcoming updates (2.9.X/2.10.X/2.XX/...) following all changes related to database feature in main Skript repo.
Thank you for making this possible.