add LPC1768 OR LPC1769 capability for board that can have either #27586
+15
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if this is tied to newer SBASE board versions, but that's the problem we run into when we're not precise with those while adding boards 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It was discovered that some boards can have either a LPC1768 or LPC1769
In particular a MKS_SBASE was just recently found in the wild with a LPC1769
When looking into this I also noticed that the SMOOTHIEBOARD also didn't accept LPC1768 or LPC1769 and I know from personal experience this board can have either
Before someone says what about the BTT_SKR_V1_4, it has LPC1768 and LPC1769
No it doesnt
BTT_SKR_V1_4 is LPC1768 while BTT_SKR_V1_4_TURBO is LPC1769
Requirements
SMOOTHIEBOARD or MKS_SBASE board with either LPC1768 or LPC1769
Benefits
Builds as expected
Related Issues
https://discord.com/channels/461605380783472640/1315708058353143939/1316814832502050836