MDBF-801: Add github status link to full Buildbot results#4201
Closed
grooverdan wants to merge 1 commit intoMariaDB:mainfrom
Closed
MDBF-801: Add github status link to full Buildbot results#4201grooverdan wants to merge 1 commit intoMariaDB:mainfrom
grooverdan wants to merge 1 commit intoMariaDB:mainfrom
Conversation
This enable users that submit pull requests to be able to easily see the link to the full test results of BuildBot.
Contributor
|
GitHub Action, woah I’m not fond of letting a bot take over every 1st floor after OP, though, be it a spell checker or even @CLAassistant. |
Member
Author
|
back to MariaDB/buildbot#743 perhaps |
Member
|
I agree with @ParadoxV5 here. That is, I don't mind when a bot takes over every 1st floor after OP, if needed. But there's a dedicated section in the PR for CI links, and comments aren't where everyone expects a CI link. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This enable users that submit pull requests to be able to easily see the link to the full test results of BuildBot.
As @ParadoxV5 commented when prompted about the mistake #4200 fixed, "why do no S390x builders advertise themselves to PRs?". With this, we can make it obvious rather than having users know /remember specific URL patterns.
Release Notes
nothing
How can this PR be tested?
See if the next PR gets a friendly GH comment.
Concept tested by @RazvanLiviuVarzaru
RazvanLiviuVarzaru/buildbot-r#7
If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually.
Basing the PR against the correct MariaDB version
mainbranch.PR quality check