Install PAM modules and systemd units from /lib to /usr/lib #4065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svoj
added
the
External Contribution
Since Fedora 17 and about 2012, the directory /lib has been a symlink to /usr/lib. Debian started a similar migration in 2019. Nowadays all major Linux distributions have a merged /usr, and the canonical location for files should be /usr/lib instead of just /lib. The location of PAM modules and systemd files is the last remaining part in MariaDB to fully complete the usr merge migration. Stable releases should not move files around, so target MariaDB 11.8 as the first release to have the /usr merge fully completed. References: - https://fedoraproject.org/wiki/Features/UsrMove - https://www.debian.org/releases/bookworm/amd64/release-notes/ch-information.en.html#a-merged-usr-is-now-required - https://www.freedesktop.org/wiki/Software/systemd/TheCaseForTheUsrMerge/
|
Job buildbot/amd64-debian-11-debug-ps-embedded failed on test unrelated to changes in this PR: |
|
Job buildbot/amd64-ubuntu-2004-debug failed on test unrelated to changes in this PR: |
grooverdan
approved these changes
May 25, 2025
There was a problem hiding this comment.
Looks good.
After validating SLES/OpenSUSE and RHEL this can continue on the RPM side (noting the Fedora change https://fedoraproject.org/wiki/Changes/Unify_bin_and_sbin).
This has almost certainly missed the 11.8 stable GA release.
Given the symlinking that has been in place for a long time and services that reference these non-user files don't do so by full path maybe there isn't a concern in changing the install location?
|
OpenSUSE implemented the I don't have access to a SUSE system to check, but pretty sure if has it already. Fedora did the change in 2012 and presumably RHEL 7 in 2014 had it (10+ years ago). |
|
ack. Interesting not visible in the BCI which I thought was SLES based: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since Fedora 17 and about 2012, the directory /lib has been a symlink to /usr/lib. Debian started a similar migration in 2019. Nowadays all major Linux distributions have a merged /usr, and the canonical location for files should be /usr/lib instead of just /lib.
The location of PAM modules and systemd files is the last remaining part in MariaDB to fully complete the usr merge migration. Stable releases should not move files around, so target MariaDB 11.8 as the first release to have the /usr merge fully completed.
References:
Release Notes
How can this PR be tested?
CI should continue to be green for builds, installs and upgrades.
Basing the PR against the correct MariaDB version
PR quality check