MDEV-36843 : Galera tests fail if wsrep_provider_options is too long … #4053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janlindstrom
force-pushed
the
11.4-MDEV-36843
branch
from
731cefa to
26171aa
Compare
janlindstrom
force-pushed
the
11.4-MDEV-36843
branch
from
26171aa to
7ecdadb
Compare
vuvova
approved these changes
Oct 16, 2025
| wsrep-debug=1 | ||
|
|
||
| [mysqld.1] | ||
| wsrep_provider_options='socket.ssl=yes;[email protected]_TEST_DIR/std_data/galera-cert.pem;[email protected]_TEST_DIR/std_data/galera-key.pem;repl.causal_read_timeout=PT90S;[email protected].#galera_port;evs.suspect_timeout=PT10S;evs.inactive_timeout=PT30S;evs.install_timeout=PT15S;pc.wait_prim_timeout=PT60S;gcache.size=10M' |
Member
There was a problem hiding this comment.
does it test the bug? how can you know it'll be above 2K?
Contributor
Author
There was a problem hiding this comment.
Test case has --eval SELECT LENGTH('$wsrep_provider_options_orig') > 2000 AS_EXPECT_1;
provider options contain also paths so they are long
janlindstrom
force-pushed
the
11.4-MDEV-36843
branch
4 times, most recently
from
dbd16c6 to
1a39e66
Compare
…(> 2k) Galera provider options contains many options and several directory names and file names that could lead situation where wsrep_provider_options string is longer than 2k. Many tests set few new options required by test and then restore wsrep_provider_options to original value. This restoring wsrep_provider_options string to original value then fails because of common limit for all charptr variables (2k). Fix is to increase common limit for all charptr variables to 4kb.
janlindstrom
force-pushed
the
11.4-MDEV-36843
branch
from
1a39e66 to
5bb8b44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…(> 2k)
Description
Galera provider options contains many options and several directory names and file names that could lead situation where wsrep_provider_options string is longer than 2k. Many tests set few new options required by test and then restore wsrep_provider_options to original value. This restoring wsrep_provider_options string to original value then fails because of common limit for all charptr variables (2k).
Fix is to increase common limit for all charptr variables to 4kb.
Release Notes
TODO: What should the release notes say about this change?
Include any changed system variables, status variables or behaviour. Optionally list any https://mariadb.com/kb/ pages that need changing.
How can this PR be tested?
TODO: modify the automated test suite to verify that the PR causes MariaDB to behave as intended.
Consult the documentation on "Writing good test cases".
If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually.
Basing the PR against the correct MariaDB version
mainbranch.PR quality check