Skip to content

MDEV-36330: SERIALIZABLE read inconsistency #4050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 10.6
Choose a base branch
from
Open

MDEV-36330: SERIALIZABLE read inconsistency #4050

wants to merge 1 commit into from

Conversation

dr-m
Copy link
Contributor

@dr-m dr-m commented May 19, 2025

  • The Jira issue number for this PR is: MDEV-36330

Description

trans_begin(): At SERIALIZABLE isolation level, handle START TRANSACTION in the same way as START TRANSACTION WITH CONSISTENT SNAPSHOT so that write/read conflicts can be detected.

innobase_start_trx_and_assign_read_view(): At any other isolation level than READ UNCOMMITTED, do create a read view. This is needed so that at SERIALIZABLE isolation level and innodb_snapshot_isolation=ON we are able to flag ER_CHECKREAD when reading data that was committed after the transaction started.

Release Notes

Transactions running at SERIALIZABLE isolation level failed to return ER_CHECKREAD for non-serializable executions (reading data that was committed after the current transaction started) even if innodb_snapshot_isolation=ON.

How can this PR be tested?

./mtr innodb.lock_isolation

Basing the PR against the correct MariaDB version

  • This is a new feature or a refactoring, and the PR is based against the main branch.
  • This is a bug fix, and the PR is based against the earliest maintained branch in which the bug can be reproduced.

PR quality check

  • I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

trans_begin(): At SERIALIZABLE isolation level, handle
START TRANSACTION in the same way as
START TRANSACTION WITH CONSISTENT SNAPSHOT
so that write/read conflicts can be detected.

innobase_start_trx_and_assign_read_view(): At any other isolation level
than READ UNCOMMITTED, do create a read view. This is needed so that at
SERIALIZABLE isolation level and innodb_snapshot_isolation=ON we are able
to flag ER_CHECKREAD when reading data that was committed after the
transaction started.
@dr-m dr-m requested a review from vuvova May 19, 2025 09:56
@dr-m dr-m self-assigned this May 19, 2025
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants