MDEV-32294 fix_fields() problem with inconsistent outer context paths #4044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mariadb-RexJohnston
force-pushed
the
10.11-MDEV-32294
branch
from
fdab7f6 to
66fb778
Compare
mariadb-RexJohnston
changed the title
During a derived table merge, we exclude the select_lex being merged into it's parent. MySQL fixes context paths in SELECT_LEX::exclude_level This patch introduces the same context exclusion.
mariadb-RexJohnston
force-pushed
the
10.11-MDEV-32294
branch
from
66fb778 to
bdfcf9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Exclude associated contexts when excluding SELECT_LEXs. These exclusions can happen when merging derived tables into the parent SELECT_LEX. Later, attempting to call fix_fields() on an Item that interacts with a merged SELECT_LEX should not be able to access a context associated with a merged select.
Release Notes
Usage of outer references in merged selects can cause problems, especially in prepared statements.
PR quality check