Bugfix: Prevent slow getRoute calls from overriding faster ones #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntroducing an isActive flag.
Lucaci-Andrei
approved these changes
Jun 11, 2025
matbmapspeople
approved these changes
Jun 12, 2025
ammapspeople
deleted the
bugfix/prevent-browser-position-from-taking-over-routing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Prevent slower getRoute calls from overtaking faster ones.
Why
In the case of eg. My Position being used, and the position is far away from the current venue, external directions responses can be extremely slow. This had the result of overriding a faster route call then the slow response finally resolved, leading to a sudden jump to an unexpected route.
How
isActiveflag to prevent older ones from overtaking. The cleanup function whereisActiveis set to false is always run before the effect runs again.