rule no-invalid-xpath: fix a eslint crash

lib/rules/no-invalid-xpath.js

@@ -66,6 +66,10 @@ const create = context => {
 		'CallExpression[callee.object.name=\'document\'][callee.property.name=\'evaluate\'][arguments.length > 0]': node => {
 			const xpathExpression = node.arguments[0].value
 
+			if (typeof xpathExpression != "string") {
+				return;
+			}
+
 			if (xpathExpression.length > 100) {
 				context.report({node, message: "large XPath expression detected"})
 			}

lib/rules/no-reuse-function-name.js

@@ -0,0 +1,28 @@
+'use strict';
+
+const create = context => {
+	return {
+		"FunctionDeclaration[id.name] VariableDeclarator[id.name]": node => {
+      const functionName = node.id.name;
+
+      if (functionName != node.parent.parent.parent.id.name) {
+        return;
+      }
+        context.report({
+          node,
+          message: `valid but see https://gist.github.com/bakkot/24c28836580a94989084`,
+        });
+      }
+	};
+};
+
+module.exports = {
+	create,
+	meta: {
+		docs: {
+			description: "TODO"
+			//url: getDocsUrl(__filename)
+		},
+		fixable: 'code'
+	}
+};

tests/lib/rules/no-invalid-xpath.js

@@ -70,6 +70,10 @@ ruleTester.run("no-invalid-xpath", rule, {
       {
         code: "document.evaluate(\"/html/body[0] | /html[0]\", document)",
       },
+      // var str = "//test";\ndocument.evaluate(str, body);
+      {
+        code: "var t = ''; \n document.evaluate(t, body);"
+      },
     ],
 
     invalid: [

tests/lib/rules/no-reuse-function-name.js

@@ -0,0 +1,46 @@
+/**
+ * @fileoverview 
+ * @author Emmanuel
+ */
+"use strict";
+
+const rule = require("../../../lib/rules/no-reuse-function-name")
+const RuleTester = require("eslint").RuleTester
+
+var ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 2017 } });
+ruleTester.run("no-reuse-function-name", rule, {
+
+    valid: [
+      {
+        code: "function x(){const a = 1;}",
+      },
+      {
+        code: "function a(){const x = 1;}",
+      },
+      {
+        code: "const x = function (){const x = 1;}",
+      },
+      // from https://gist.github.com/bakkot/24c28836580a94989084
+      {
+        code: "(function x(){\"use strict\"; x = 1;}());", // TypeError in Chrome
+      },
+      {
+        code: "(function x(){x = 1; return x !== 1;}());", // write fails silently; function returns true
+      },
+    ],
+
+    invalid: [
+        {
+            code: "function x(){const x = 1;}",
+            errors: [{
+                message: "valid but see https://gist.github.com/bakkot/24c28836580a94989084",
+            }]
+        },
+        {
+            code: "function x(){const a = 1; const x = 2}",
+            errors: [{
+                message: "valid but see https://gist.github.com/bakkot/24c28836580a94989084",
+            }]
+        },
+    ]
+});