Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Scan node as auxiliary item #90

Merged
merged 2 commits into from
Mar 25, 2025
Merged

Added Scan node as auxiliary item #90

merged 2 commits into from
Mar 25, 2025

Conversation

mlorenz49
Copy link
Contributor

This pull request includes updates to the alpharaw/thermo.py file to add support for scan_node parameter. The changes ensure that the scan_node parameter is included in the auxiliary items and properly handled during batch import.

The scan node information is extracted using the GetTrailerExtraInformation which is already implemented in pythermorawfilereader.GetTrailerExtraForScanNum.

Scan node information is now parsed when added to auxiliary_items list.
@mlorenz49 mlorenz49 requested review from GeorgWa and mschwoer March 21, 2025 13:55
@mlorenz49 mlorenz49 self-assigned this Mar 21, 2025
Copy link

Number of tokens: input_tokens=6263 output_tokens=974 max_tokens=4096
review_instructions=''
config={}
thinking: ```
[]

Copy link
Contributor

@mschwoer mschwoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlorenz49 mlorenz49 merged commit 5bcb8b7 into main Mar 25, 2025
2 checks passed
@mlorenz49 mlorenz49 deleted the header-read-node branch March 25, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants