Fix pickle #428
Fix pickle #428
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances session management by adding support for an alternative serialization library (dill) and by handling multiple file extensions for session files.
- Introduces dill as a fallback when cloudpickle fails during serialization.
- Adds support for two file extensions (cpkl and dpkl) in both saving and loading sessions.
Comments suppressed due to low confidence (2)
alphastats/gui/utils/session_manager.py:36
- [nitpick] Consider using more descriptive constant names (e.g., CLOUDPICKLE_EXT and DILL_EXT) to improve code readability.
_EXT_C = "cpkl"
alphastats/gui/utils/session_manager.py:125
- If the file suffix is not '.cpkl' or '.dpkl', the code does not initialize 'loaded_data', which may lead to an undefined variable error. Consider adding an else block to handle unexpected file extensions.
if file_path.exists():
|
Still raises with a chat session: File "/Users/schessner/anaconda3/envs/alphastats_dev/lib/python3.9/site-packages/streamlit/runtime/scriptrunner/exec_code.py", line 88, in exec_func_with_error_handling |
|
I think we need to skip the LLMIntegration object and instead only save the serializable attributes of it. |
This pull request enhances the session management functionality in
alphastatsby introducing support for an additional serialization library (dill) alongside the existingcloudpickle. It also updates the session saving and loading mechanisms to handle multiple file extensions and improve compatibility.Serialization Enhancements:
dillas an alternative serialization library to handle cases wherecloudpicklefails. (alphastats/gui/utils/session_manager.py) [1] [2]dpkl) for files serialized withdill, alongside the existingcpklforcloudpickle. (alphastats/gui/utils/session_manager.py) [1] [2]Session Management Updates:
get_saved_sessionsto support bothcpklanddpklfile extensions when retrieving saved session files. (alphastats/gui/utils/session_manager.py)savemethod to attempt serialization withcloudpicklefirst, falling back todillif an exception occurs. (alphastats/gui/utils/session_manager.py)loadmethod to correctly identify and deserialize files based on their extensions (cpklordpkl). (alphastats/gui/utils/session_manager.py)