move session state keys to dedicated module #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuliaS92
reviewed
Mar 11, 2025
alphastats/gui/utils/state_keys.py
Outdated
| @@ -0,0 +1,28 @@ | |||
| """Keys and helper functions for the session state.""" | |||
There was a problem hiding this comment.
Why are the functions and the keys in two separate files now?
If that has a good reason, please remove the 'helper functions' from the docs here and explain instead where they are.
There was a problem hiding this comment.
sorry for not mentioning this: the motivation was to resolve a circular import provlem in #403
JuliaS92
reviewed
Mar 11, 2025
| @@ -4,7 +4,8 @@ | |||
| import pandas as pd | |||
| import streamlit as st | |||
|
|
|||
| from alphastats.gui.utils.ui_helper import DefaultStates, StateKeys | |||
| from alphastats.gui.utils.state_keys import StateKeys | |||
| from alphastats.gui.utils.ui_helper import DefaultStates | |||
There was a problem hiding this comment.
Why are the default states not moved, too?
There was a problem hiding this comment.
circular imports again :-)
JuliaS92
reviewed
Mar 11, 2025
Comment on lines
+7
to
+8
| from alphastats.gui.utils.state_keys import StateKeys | ||
| from alphastats.gui.utils.ui_helper import DefaultStates |
There was a problem hiding this comment.
If we were to move the defaults as well it might make sense to create:
- alphastats.gui.utils.state.keys
- alphastats.gui.utils.state.defaults
- alphastats.gui.utils.state.utils
There was a problem hiding this comment.
if this further grows, might make sense one day.. for now, I'd like to keep it flat
JuliaS92
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move session state keys to dedicated module