Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor config2 #415

Open
wants to merge 6 commits into
base: change_config_handling
Choose a base branch
from
Open

Refactor config2 #415

wants to merge 6 commits into from

Conversation

mschwoer
Copy link
Collaborator

  • make the config an actual dict, simplify the way it is initialized
  • remove ability to set config_base_path

@mschwoer mschwoer requested a review from GeorgWa December 20, 2024 15:38
@mschwoer mschwoer force-pushed the refactor_config2 branch 2 times, most recently from 1e853ea to 0d62ae9 Compare December 20, 2024 17:09
@mschwoer mschwoer added test:e2e End to end tests will be run on PRs that carry this label. and removed test:e2e End to end tests will be run on PRs that carry this label. labels Dec 20, 2024
@mschwoer mschwoer added test:e2e End to end tests will be run on PRs that carry this label. and removed test:e2e End to end tests will be run on PRs that carry this label. labels Dec 20, 2024
@mschwoer mschwoer added the test:e2e End to end tests will be run on PRs that carry this label. label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgWa GeorgWa Awaiting requested review from GeorgWa

Assignees
No one assigned
Labels
test:e2e End to end tests will be run on PRs that carry this label.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mschwoer