-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multistep search #399
base: development
Are you sure you want to change the base?
Multistep search #399
Conversation
I think this fits the idea very well apart from how the user triggers it. Ideally the user should have two Boolean arguments:
the first one will prepend a transfer learning to the main search, the second one will append the MBR search to the main search. The config specification of what should be overwritten looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
alphadia/constants/multistep.yaml
Outdated
library: | ||
general: | ||
save_library: False | ||
library_prediction: # needs to be done if transfer AND/OR mbr enabled? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional if MBR search, mandatory if TL search
alphadia/constants/multistep.yaml
Outdated
|
||
mbr: | ||
general: | ||
reuse_quant: True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, reuse_quant is not needed.
alphadia/planning.py
Outdated
@@ -328,13 +347,18 @@ def run( | |||
logger.progress("Starting Search Workflows") | |||
|
|||
workflow_folder_list = [] | |||
single_estimators = defaultdict( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use estimator already in the calibration. This is the results of the hyper parameter optimisation. So it could be optimised parameters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea, but will be read from stats.tsv anyway
version 1:
update 1:
update 2:
This PR adds the multistep search including tests, UI, docs, and e2e tests.