Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rt length to output ii #373

Merged
merged 14 commits into from
Nov 19, 2024
Merged

Add rt length to output ii #373

merged 14 commits into from
Nov 19, 2024

Conversation

mschwoer
Copy link
Collaborator

@mschwoer mschwoer commented Nov 13, 2024 •
edited
Loading

First guess at what should be added in terms of raw file stats.

Also some renamings and refactoring of the pickle code.

cf. also #368

@mschwoer mschwoer mentioned this pull request Nov 14, 2024
Closed
GeorgWa
GeorgWa approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@GeorgWa GeorgWa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think switching to time units as minutes is an important one. Everything else is good to go.

alphadia/outputtransform.py Outdated Show resolved Hide resolved
alphadia/workflow/manager.py Show resolved Hide resolved
alphadia/workflow/managers/raw_file_manager.py Show resolved Hide resolved
nbs/tutorial_nbs/logging.ipynb Outdated Show resolved Hide resolved
GeorgWa
GeorgWa approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@GeorgWa GeorgWa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from add_rt_length_to_output to development November 19, 2024 08:51
@mschwoer mschwoer merged commit db55495 into development Nov 19, 2024
5 checks passed
@mschwoer mschwoer deleted the add_rt_length_to_output_II branch November 19, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgWa GeorgWa GeorgWa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mschwoer @GeorgWa