Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uname issue #201

Merged
merged 4 commits into from
Jun 1, 2024
Merged

Fix uname issue #201

merged 4 commits into from
Jun 1, 2024

Conversation

mschwoer
Copy link
Collaborator

@mschwoer mschwoer commented May 31, 2024

Fixing an issue reported by @vbrennsteiner .

I created a release already from this branch to enable re-testing.

0:01:39.853910 PROGRESS: Predicting library properties.
0:01:39.853910 INFO: Running PeptDeepPrediction
0:01:39.853910 INFO: Traceback (most recent call last):
  File "alphadia\cli.py", line 333, in run
    plan = Plan(
           ^^^^^
  File "alphadia\planning.py", line 126, in __init__
    self.load_library()
  File "alphadia\planning.py", line 229, in load_library
    spectral_library = pept_deep_prediction(spectral_library)
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "alphadia\libtransform.py", line 40, in __call__
    return self.forward(*args)
           ^^^^^^^^^^^^^^^^^^^
  File "alphadia\libtransform.py", line 304, in forward
    device = "mps" if os.uname().sysname == "Darwin" else "gpu"
                      ^^^^^^^^
AttributeError: module 'os' has no attribute 'uname'

0:01:39.853910 ERROR: module 'os' has no attribute 'uname'

@mschwoer mschwoer changed the base branch from main to development May 31, 2024 12:52
@mschwoer mschwoer requested a review from GeorgWa May 31, 2024 16:23
Copy link
Collaborator

@GeorgWa GeorgWa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alphadia/libtransform.py Show resolved Hide resolved
@GeorgWa GeorgWa marked this pull request as ready for review June 1, 2024 21:04
@GeorgWa GeorgWa merged commit 4138c15 into development Jun 1, 2024
7 checks passed
@GeorgWa GeorgWa deleted the fix_uname_issue branch June 1, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants