Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor readers xi #256

Merged
merged 19 commits into from
Jan 9, 2025
Merged

Refactor readers xi #256

merged 19 commits into from
Jan 9, 2025

Conversation

mschwoer
Copy link
Contributor

somehow github got stuck on the original PR: #253

  • simplifying the inheritance structure and avoid overwriting superclass methods with pass
  • get rid of obsolete checks on empty origin_df
  • get rid of _transform_table
  • drop hardcoding of "EG.PrecursorId"
  • move test_data_downloader.py to tools/data_downloader.py

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@mschwoer mschwoer mentioned this pull request Nov 26, 2024
Closed
jalew188
jalew188 approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@jalew188 jalew188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part looks good to me

Base automatically changed from refactor_readers_X to development January 9, 2025 16:26
@mschwoer mschwoer merged commit c265e62 into development Jan 9, 2025
3 checks passed
@mschwoer mschwoer deleted the refactor_readers_XI branch January 9, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jalew188 jalew188 jalew188 approved these changes

@GeorgWa GeorgWa Awaiting requested review from GeorgWa

@lucas-diedrich lucas-diedrich Awaiting requested review from lucas-diedrich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mschwoer @jalew188