Refactor readers ix #251
Open
Refactor readers ix #251
+153
−173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschwoer
commented
Nov 20, 2024
| @@ -251,115 +233,34 @@ def import_file(self, _file: str) -> pd.DataFrame: | |||
| self._post_process() # here, libraryreader, diann, msfragger | |||
| return self._psm_df | |||
|
|
|||
| def _pre_process(self, df: pd.DataFrame) -> pd.DataFrame: | |||
There was a problem hiding this comment.
has just been moved within the class
mschwoer
commented
Nov 20, 2024
| break | ||
| # TODO: warn if there's more | ||
| return mapped_columns | ||
| def _pre_process(self, df: pd.DataFrame) -> pd.DataFrame: |
There was a problem hiding this comment.
naming question: the original dataframe (the one loaded from disk) is sometimes referred to as df sometimes as origin_df .. any preferences? (or a third option?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reorder some methods, rename, simplify