Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor readers viii #250

Open
wants to merge 3 commits into
base: refactor_readers_VII
Choose a base branch
from
Open

Conversation

mschwoer
Copy link
Contributor

remove some obsolete constructors

@mschwoer mschwoer marked this pull request as ready for review November 21, 2024 08:45
Copy link
Collaborator

@GeorgWa GeorgWa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


self._min_max_rt_norm = True
_min_max_rt_norm = True
_fixed_c57_default = False
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we enforce that all of them must be set via an ABC?

)

self._min_max_rt_norm = True
_min_max_rt_norm = True
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is something we might rather want to do on an alphabase level as post processing

Copy link
Collaborator

@jalew188 jalew188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants