-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linting iv #236
base: linting_III
Are you sure you want to change the base?
Linting iv #236
Conversation
mschwoer
commented
Nov 15, 2024
•
edited
Loading
edited
- get rid of unused arguments
- add type hints (this used to be a seperate PR -> Linting v #237 but somehow got merged into the current one)
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This reverts commit 35dec99.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. These changes should be tested more as many kwargs are modified.
@jalew188 do you have any specific tests in mind (beside the automated integration tests)? The changes to the kwargs are only done in private methods ( Please let me know about where you have concerns. |