Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting iv #236

Open
wants to merge 11 commits into
base: linting_III
Choose a base branch
from
Open

Linting iv #236

wants to merge 11 commits into from

Conversation

mschwoer
Copy link
Contributor

@mschwoer mschwoer commented Nov 15, 2024

  • get rid of unused arguments
  • add type hints (this used to be a seperate PR -> Linting v #237 but somehow got merged into the current one)

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@jalew188 jalew188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. These changes should be tested more as many kwargs are modified.

@mschwoer
Copy link
Contributor Author

@jalew188 do you have any specific tests in mind (beside the automated integration tests)? The changes to the kwargs are only done in private methods (_translate_decoy,
_translate_score, _post_process, _get_table_delimiter). The subtle (but in fach breaking) change in parse_pfind_protein was done as it is not used within the whole mann labs github..

Please let me know about where you have concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants