Linting iii#235
Merged
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This reverts commit 35dec99.
GeorgWa
approved these changes
Nov 20, 2024
GeorgWa
left a comment
GeorgWa
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
I think the Path() / Path() syntax is quite ugly and missuses python magic methods :D but if the community thinks this is the way to go I'm happy to do so.
I'm also not a big fan of ther new read only .to_numpy() buit I guess I have to live with this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
manual fixes for a first bunch of linting rules ..
see individual commits
edit: made all start imports in notebooks explicit as tests started to fail due to removal of
osfrom some readers