Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch the failing test. Note: this needs a more through solution! #192

Merged
merged 6 commits into from
Jun 28, 2024

Conversation

mschwoer
Copy link
Contributor

No description provided.

@mschwoer mschwoer requested a review from jalew188 June 28, 2024 13:00
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jalew188
Copy link
Collaborator

Looks good to me. I will add a patch to fix #169 and then we can merge.

Copy link
Collaborator

@jalew188 jalew188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jalew188 jalew188 merged commit ca05c60 into development Jun 28, 2024
2 checks passed
@jalew188 jalew188 deleted the patch_test branch June 28, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants