Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cubic bézier bounding box calculation to width/height attribute :class:.VMobject #3625

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jsonvillanueva
Copy link
Member

@jsonvillanueva jsonvillanueva commented Feb 16, 2024

Overview: What does this pull request change?

Widths and heights of :class:.VMobject no longer simply use its control points handles to calculate the bounding box.

It also removes some dead code related to cubic bezier curves that isn't used in VMobject (simplifying it) and moves some logic specific to the Cubic Bezier out of VMobject.

Motivation and Explanation: Why and how do your changes improve the library?

Closes #3619

Links to added or changed documentation pages

Further Information and Comments

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

@jsonvillanueva jsonvillanueva added the pr:bugfix Bug fix for use in PRs solving a specific issue:bug label Feb 16, 2024
@MrDiver
Copy link
Collaborator

MrDiver commented Apr 1, 2024

Is this ready for review?
Do we need to update the test?

@behackl
Copy link
Member

behackl commented Apr 24, 2024

Judging from the CI output some more work is required here; I'll mark this as a draft.

@behackl behackl marked this pull request as draft April 24, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:bugfix Bug fix for use in PRs solving a specific issue:bug
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

VMobject inaccurately attributes width/height attrs to its bézier control points
3 participants