Skip to content

Settings replication form #9323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

liu-samuel
Copy link
Contributor

@liu-samuel liu-samuel commented Jan 10, 2025

Moved the form to a modal without needing to replace the whole form, need to still implement data persisting through the modal for adding new subscriptions and for updating existing subscriptions

@liu-samuel liu-samuel requested a review from a team as a code owner January 10, 2025 03:03
@GilbertCherrie GilbertCherrie self-assigned this Jan 13, 2025
@miq-bot
Copy link
Member

miq-bot commented Mar 5, 2025

Checked commits liu-samuel/manageiq-ui-classic@f97059e~...c16baa0 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
1 file checked, 1 offense detected

app/views/ops/_settings_replication_tab.html.haml

  • ⚠️ - Line 2 - id attribute must be in lisp-case

@miq-bot
Copy link
Member

miq-bot commented Jun 9, 2025

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

@miq-bot miq-bot added the stale label Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants